1525409 - Move the Disk IO payload's operation from the marker name to the payload

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P1)

Description

[Greg Tatum [:gregtatum]]

Running "copy marker" from perf.html's interface on an existing DiskIO marker yields:

{
  "start":405.1727087761472,
  "dur":0.1958461417349895,
  "name":"create/open",
  "data":{
    "type":"io",
    "startTime":405.1727087761472,
    "endTime":405.3685549178822,
    "source":"PoisonIOInterposer",
    "filename":"C:\\Users\\florian",
    "cause": {
      "time":405.37047497809533,
      "stack":29742
    }
  },
  "title":null
}

However it will fit in better to the existing UI if instead it is formatted as

{
  "start":405.1727087761472,
  "dur":0.1958461417349895,
  "name":"DiskIO",
  "data":{
    "type":"DiskIO",
    "startTime":405.1727087761472,
    "endTime":405.3685549178822,
    "source":"PoisonIOInterposer",
    "operation":"create/open",
    "filename":"C:\\Users\\florian",
    "cause": {
      "time":405.37047497809533,
      "stack":29742
    }
  },
  "title":null
}

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1525409 - Rework the IOMarkerPayload structure to include better information; r=florian

Comment 2

[Greg Tatum [:gregtatum]]

I'll be submitting a deploy preview as well.

Comment 3

[Greg Tatum [:gregtatum]]

These are the deploy previews showing the use of the new data structure. Now you can search for "DiskIO" and they will be filtered in the UI.

Marker chart deploy preview
Marker table deploy preview

And this is the PR: https://github.com/devtools-html/perf.html/pull/1729

Comment 4

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=74d4031b68ae2af258d211cc45c32bce0202a066

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc9cf96cb4bb
Rework the IOMarkerPayload structure to include better information; r=gerald

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fc9cf96cb4bb