1525419 - environment variables containing | cause errors

Status: RESOLVED FIXED

(Taskcluster :: Workers, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

https://taskcluster-web.netlify.com/tasks/PPyVZMKHSCS0O8BvvD7WZg
has

Env: {
   ..
   "TRY_COMMIT_MSG": "Fuzzy query=android | linux | windows jittest\n\nPushed via `mach try fuzzy`",
}

and causes

'linux' is not recognized as an internal or external command,
operable program or batch file.

I think because it's not escaped in https://github.com/taskcluster/generic-worker/blob/ef584fdea9b9903dc1bb1e3e78b6233e5ca8f010/plat_windows.go#L309

Comment 1

[Andrew Halberstadt [:ahal]]

This breaks mach try fuzzy as | is a common operator in its syntax.

I think this is a fairly recent regression, just based on the fact that I regularly use fuzzy and haven't run into this until yesterday.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

It was a regression in how we handle commit messages in-tree (bug 1525421). That just happened to tickle this bug in generic-worker.

Comment 3

[Pete Moore [:pmoore][:pete]]

Ouch. Do you happen to know if this is only a problem on Windows?

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

I don't recall for sure, no, but given the link to plat_windows.go in comment 0 and given that generic-worker doesn't do any escaping or other handling of env var values on POSIX, I'd expect so.

Comment 5

[Pete Moore [:pmoore][:pete]]

Attachment: GitHub Pull Request for taskcluster monorepo

Comment 6

[Pete Moore [:pmoore][:pete]]

Looks like I forgot to update this bug when it landed.

Comment 7

[Pete Moore [:pmoore][:pete]]

Released in https://github.com/taskcluster/taskcluster/releases/tag/v28.2.3