Closed Bug 1525421 Opened 6 years ago Closed 6 years ago

Only pass on commit message if it has try syntax

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: dustin, Assigned: dustin)

Details

Attachments

(1 file)

Bug 1525421 - parse out just the try syntax from the commit message
47 bytes, text/x-phabricator-request
Details | Review

This can easily be transplanted or merged into mozilla-central if that's urgent.

Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b0547c09b35 parse out just the try syntax from the commit message r=tomprince

Backed out changeset 1b0547c09b35 (Bug 1525421) for geko decision task bustage

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&revision=1b0547c09b3558b283ff590c37efc12435ea39c1&selectedJob=226695307

Backout link: https://hg.mozilla.org/integration/autoland/rev/d09706f38e5e90e3a7754c48463ea1bd5077ae12

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226695307&repo=autoland&lineNumber=54

[vcs 2019-02-07T02:01:26.694Z] TinderboxPrint:<a href=https://hg.mozilla.org/integration/autoland/rev/1b0547c09b3558b283ff590c37efc12435ea39c1 title='Built from autoland revision 1b0547c09b3558b283ff590c37efc12435ea39c1'>1b0547c09b3558b283ff590c37efc12435ea39c1</a>
[task 2019-02-07T02:01:26.694Z] executing ['bash', '-cx', 'cd /builds/worker/checkouts/gecko && ln -s /builds/worker/artifacts artifacts && ./mach --log-no-times taskgraph decision --pushlog-id='77616' --pushdate='1549504851' --project='autoland' --owner='dmitchell@mozilla.com' --level='3' --base-repository="$GECKO_BASE_REPOSITORY" --head-repository="$GECKO_HEAD_REPOSITORY" --head-ref="$GECKO_HEAD_REF" --head-rev="$GECKO_HEAD_REV" \n']
[task 2019-02-07T02:01:26.696Z] + cd /builds/worker/checkouts/gecko
[task 2019-02-07T02:01:26.696Z] + ln -s /builds/worker/artifacts artifacts
[task 2019-02-07T02:01:26.697Z] + ./mach --log-no-times taskgraph decision --pushlog-id=77616 --pushdate=1549504851 --project=autoland --owner=dmitchell@mozilla.com --level=3 --base-repository=https://hg.mozilla.org/mozilla-unified --head-repository=https://hg.mozilla.org/integration/autoland --head-ref=1b0547c09b3558b283ff590c37efc12435ea39c1 --head-rev=1b0547c09b3558b283ff590c37efc12435ea39c1
[task 2019-02-07T02:01:27.182Z] Loading graph configuration.
[task 2019-02-07T02:01:27.183Z] loading config from taskcluster/ci/config.yml
[task 2019-02-07T02:01:27.208Z] Traceback (most recent call last):
[task 2019-02-07T02:01:27.208Z] File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 190, in taskgraph_decision
[task 2019-02-07T02:01:27.208Z] return taskgraph.decision.taskgraph_decision(options)
[task 2019-02-07T02:01:27.208Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 167, in taskgraph_decision
[task 2019-02-07T02:01:27.208Z] write_artifact('parameters.yml', dict(**tgg.parameters))
[task 2019-02-07T02:01:27.208Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 131, in parameters
[task 2019-02-07T02:01:27.208Z] return self._run_until('parameters')
[task 2019-02-07T02:01:27.208Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 341, in _run_until
[task 2019-02-07T02:01:27.208Z] k, v = self._run.next()
[task 2019-02-07T02:01:27.208Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 225, in _run
[task 2019-02-07T02:01:27.208Z] parameters = self._parameters(graph_config)
[task 2019-02-07T02:01:27.208Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 159, in <lambda>
[task 2019-02-07T02:01:27.208Z] parameters = parameters or (lambda config: get_decision_parameters(config, options))
[task 2019-02-07T02:01:27.209Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 236, in get_decision_parameters
[task 2019-02-07T02:01:27.209Z] get_hg_commit_message(GECKO, product_dir))
[task 2019-02-07T02:01:27.209Z] TypeError: get_hg_commit_message() takes exactly 1 argument (2 given)
[taskcluster 2019-02-07 02:01:27.586Z] === Task Finished ===

Flags: needinfo?(dustin)
Flags: needinfo?(dustin)
Pushed by opoprus@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/7d289fe21aec parse out just the try syntax from the commit message r=tomprince

https://hg.mozilla.org/mozilla-central/rev/7d289fe21aec

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Can you uplift this to m-esr60? Apparently needed for bug 1534204.

Comment on attachment 9041609 [details]
Bug 1525421 - parse out just the try syntax from the commit message

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to support comm-central try build
  • User impact if declined: unable to push comm-esr60 to try-comm-central
  • Fix Landed on Version: 67
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): NPOTB
  • String or UUID changes made by this patch:
Attachment #9041609 - Flags: approval-mozilla-esr60?

Comment on attachment 9041609 [details]
Bug 1525421 - parse out just the try syntax from the commit message

a=tomprince

Attachment #9041609 - Flags: approval-mozilla-esr60?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: