1525477 - Remove some unreachable code from testing/web-platform/tests/tools/wpt/browser.py

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I was looking around to find something for unrelated reasons, and found this code block:
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/tools/wpt/browser.py#225-226

I don't think channel can ever be "beta" at this point in the code, since we've already passed checks for channel being "stable" or "beta". At this point, I think channel can only be "nightly" or None.

Bug 1486084 likely made this unreachable, but even before that, I don't understand how this code worked:
https://searchfox.org/mozilla-central/diff/2de7f65b584db16b96a0d988ab4df81a4c115383/testing/web-platform/tests/tools/wpt/browser.py#194-206

I think we can remove that whole block of code.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Bug 1525477 - Remove unreachable block of code in wpt/browser.py r?jgraham

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/308ac36df051
Remove unreachable block of code in wpt/browser.py r=jgraham

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/308ac36df051

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15291 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged