Closed Bug 1525515 Opened 2 years ago Closed 2 years ago

Video was sometimes not rendered after GPU process crash

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

This but is created by Bug 1504230 Comment 9.

In the following STR, there was a case that video was not rendered.

[1] Start firefox and start playback video.
[2] Open new window by dragging new tab and start playback video.
[3] Open new window by dragging new tab and open "about:support".
[4] Close GPU process by pushing "Terminate GPU Process" button.
[5] Check Tabs that were playing videos if video is rendered correctly.

During re-creating GPU process, there was a period that ImageBridgeChild was re-created, but ImageBridgeChild::UpdateTextureFactoryIdentifier() was not called yet. In the period, if ImageBridgeChild::CreateImageClient() is called, ImageBridgeParent creates incompatible ImageHost than WebRenderImageHost.

Assignee: nobody → sotaro.ikeda.g
See Also: → 1504230
See Also: → 1523522
Attachment #9041700 - Attachment is obsolete: true

With attachment 9041703 [details], the problem was addressed for me.

Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88a984a7faca
Dorp ImageClients that are created before UpdateTextureFactoryIdentifier() call r=nical
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.