1525515 - Video was sometimes not rendered after GPU process crash

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

This but is created by Bug 1504230 Comment 9.

In the following STR, there was a case that video was not rendered.

[1] Start firefox and start playback video.
[2] Open new window by dragging new tab and start playback video.
[3] Open new window by dragging new tab and open "about:support".
[4] Close GPU process by pushing "Terminate GPU Process" button.
[5] Check Tabs that were playing videos if video is rendered correctly.

During re-creating GPU process, there was a period that ImageBridgeChild was re-created, but ImageBridgeChild::UpdateTextureFactoryIdentifier() was not called yet. In the period, if ImageBridgeChild::CreateImageClient() is called, ImageBridgeParent creates incompatible ImageHost than WebRenderImageHost.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Dorp ImageClients that are created before UpdateTextureFactoryIdentifier() call

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1525515 - Dorp ImageClients that are created before UpdateTextureFactoryIdentifier() call

Comment 3

[Sotaro Ikeda [:sotaro]]

With attachment 9041703 [details], the problem was addressed for me.

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c4c5eb492df933dbbd8254fb25bae6475e358d0

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88a984a7faca
Dorp ImageClients that are created before UpdateTextureFactoryIdentifier() call r=nical

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/88a984a7faca