Video was sometimes not rendered after GPU process crash

RESOLVED FIXED in Firefox 67

Status

()

RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 months ago

This but is created by Bug 1504230 Comment 9.

In the following STR, there was a case that video was not rendered.

[1] Start firefox and start playback video.
[2] Open new window by dragging new tab and start playback video.
[3] Open new window by dragging new tab and open "about:support".
[4] Close GPU process by pushing "Terminate GPU Process" button.
[5] Check Tabs that were playing videos if video is rendered correctly.

During re-creating GPU process, there was a period that ImageBridgeChild was re-created, but ImageBridgeChild::UpdateTextureFactoryIdentifier() was not called yet. In the period, if ImageBridgeChild::CreateImageClient() is called, ImageBridgeParent creates incompatible ImageHost than WebRenderImageHost.

(Assignee)

Updated

2 months ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Updated

2 months ago
See Also: → bug 1504230
(Assignee)

Updated

2 months ago
See Also: → bug 1523522
(Assignee)

Updated

2 months ago
Attachment #9041700 - Attachment is obsolete: true
(Assignee)

Comment 3

2 months ago

With attachment 9041703 [details], the problem was addressed for me.

Comment 5

2 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88a984a7faca
Dorp ImageClients that are created before UpdateTextureFactoryIdentifier() call r=nical

Comment 6

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.