1525525 - 6.29 - 7.12% sessionrestore / sessionrestore_no_auto_restore / ts_paint / ts_paint_webext (windows7-32) regression on push 30a8448f1d2735ebf730f3b79443a574ed7a8629 (Tue Feb 5 2019)

Status: RESOLVED WONTFIX

(Core :: Security, defect)

Description

[Florin Strugariu [:Bebe]]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=30a8448f1d2735ebf730f3b79443a574ed7a8629

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

7% ts_paint_webext windows7-32 pgo e10s stylo 312.50 -> 334.75
7% sessionrestore_no_auto_restore windows7-32 pgo e10s stylo 317.42 -> 339.67
7% ts_paint windows7-32 pgo e10s stylo 313.83 -> 335.42
6% sessionrestore windows7-32 pgo e10s stylo 298.62 -> 317.42

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=19170

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Comment 1

[Florin Strugariu [:Bebe]]

:tjr can you take a look over this regression

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1485016#c22 I believe we are okay with these regressions. I'll pass to jmaher to confirm...

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

redirecting to igoldan, he can answer this most accurately

Comment 4

[Ionuț Goldan [:igoldan]]

I'm checking the impact of the landed changes from both Talos and Raptor's perspective right here.

Comment 5

[Ionuț Goldan [:igoldan]]

(In reply to Tom Ritter [:tjr] from comment #2)

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1485016#c22 I believe we are okay with these regressions. I'll pass to jmaher to confirm...

I only noticed an extra 4% ts_paint_webext on Windows 10. Raptor didn't come up with other surprises.
I'd say we can accept these.