152553 - "Show Anonymous Content" menu item doesn't reflect state

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[[e-mail]]

Build ID: 2002061104

In the DOM Inspector, clicking on View->Show Anonymous Content, does nothing. By
default, it's on. So I can't seem to turn off the viewing of anonymous content.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

I know this works because I was using this earlier today on a fresh build. 
Reporter, are you just not seeing anything become hidden?  I suppose I should
ask: do you know what anonymous content is?  If you do, then try a build from
like today (rather than last week) and see if that helps.  If not, then please
don't file bugs on a feature you don't understand.  ;-)

Comment 2

[[e-mail]]

Well, I'm currently using the build - 2002061808. (Win2k)

And I guess I should have been more specific in mentioning that the check
against the menu-item "Show Anonymous Content" in the "View" menu, refuses to go
off, when I click on it.
I'm still downloading today's build, and when I get that, I'll check with that
again.
I don't have any XML with anonymous content to test with, so I don't know what
would happen then, but considering that the check in the menu doesn't go off,
I'd think _something_ was wrong.

Comment 3

[[e-mail]]

Build ID: 2002062408

I still see the same behaviour. The checkbox doesn't go off. If someone could
direct me to the documentation about what is supposed to happen (I guess it
would be too much to expect a Use Case? ;) ) when I click on the "Show Anonymous
Content" menu-item, I might figure out what _I_ am doing wrong. But I must say I
don't see what more I need to do than click on the menu-item to get the check to
go away ...

Note: I'm not saying anything about the content I see, and how that is affected.
I'm only talking about the state of the menu.

Comment 4

[timeless]

the only problem is that the checkmark doesn't go away, if you inspect chrome 
you'll see red items in one state, and you won't in the other.

I've tried fixing this, I couldn't figure out how to do it.

Comment 5

[Michael Lefevre]

well I don't know what it does, but the checkmark comes and goes just fine for
me with 2002080508/trunk/win2k.

reporter: can you still reproduce this bug with a recent build of mozilla? if
so, please comment again with details. if not, please resolve this bug as
WORKSFORME. thanks.

Comment 6

[[e-mail]]

Ok. I'm using the latest build which I downloaded 10 minutes ago. 
Build ID: 2002080704

I open a random XML file on my machine. I click 'View', and "Show Anonymous
Content" is checked. I click on it, and the popup menu collapses (as is should).
There's nothing different in what I see on the screen, but then since I don't
have any anonymous content in the XML anyway, I guess that is ok.
I go back and click 'View', and "Show Anonymous Content" is still checked.

Comment 7

[Michael Lefevre]

ahem. I must confess I didn't actually open a file - the checkmark works fine if
you don't actually open anything :)

inspecting chrome (I don't have any XML with anonymous content lying around), I
see, as timeless said in comment 4, that the menu item does actually toggle some
content on and off, but the checkmark doesn't change state.

confirming.

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch to fix

Per the ECMA spec section 11.9.3
<http://www.mozilla.org/js/language/E262-3.pdf>
false == null will yield false.
true == null will yield false.

since we are always checking for !=, we always return true and always end up
with checkmarks.

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

me

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Boris can I get an sr= for this silly 2 liner?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 97436 [details] [diff] [review]
Patch to fix

sr=bzbarsky

Comment 12

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fixed