1525548 - Consider making all of the mochitests in browser/components/urlbar close the address bar popup automatically

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P5)

Description

[Mark Banner (:standard8)]

Currently, there's quite a few urlbar tests where we do:

registerCleanupFunction(async function() {
    await UrlbarTestUtils.promisePopupClose(window);
});

We should consider just doing that in the head file by default, and removing all the individual instances from tests.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1525548 - Centralise closing the address bar popup into the head file for urlbar tests. r?mak

Comment 2

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92d9c941a58ba0907f89e1c41b967e655fc10aea

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c261aea0226a
Centralise closing the address bar popup into the head file for urlbar tests. r=mak

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c261aea0226a