1525554 - Enable promise rejection event

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Edgar Chen [:edgar]]

It will cause the result of some tests to change, given that testharness.js is meant to fail if there are unhandled rejections [1].

[1] https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/testing/web-platform/tests/resources/testharness.js#3278-3310

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1525554 - Enable promise rejection event on nightly and update tests result;

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1525554 - Enable promise rejection event and update tests result;

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&exclusion_profile=false&group_state=expanded&revision=b446c4f5edadebfa953f990a2944d9586e90e41c

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1525554 - Fix "MojoInterfaceInterceptor is not defined" error;

which causes the promise being rejected and testharness reports error given
that there are unhandled rejected promises

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1525554 - Make audioworkletnode-output-channel-count.https.html shows correct test name;

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=347c2b46e1f16298a3ca37eb94356293e0e05382

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67cd5b8663ca
Fix "MojoInterfaceInterceptor is not defined" error; r=annevk

Comment 9

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=be0237a82a70396e45cc6865a4f1641a366496f9

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/67cd5b8663ca

Comment 11

[Edgar Chen [:edgar]]

Attachment: Bug 1525554 - Avoid testharness reporting unhandled promise rejections in pause-remove-from-document-networkState.html;

Comment 12

[Edgar Chen [:edgar]]

Attachment: Bug 1525554 - Avoid testharness reporting error casued by unhandled rejected promises in media-source/mediasource-getvideoplaybackquality.html;

Comment 13

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=33d258d5f60c16701793865a9ea36f12f77c5744

Comment 14

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4babf8131ebd136653a69ae166f71f6bb9f73b6f

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e7f893e8020
Avoid testharness reporting error casued by unhandled rejected promises in media-source/mediasource-getvideoplaybackquality.html; r=annevk

Comment 16

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=c5591aa80358474b7fa98fb90fd1cabed32f0f27&group_state=expanded

Comment 17

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7e7f893e8020

Comment 18

[Edgar Chen [:edgar]]

Attachment: Bug 1525554 - Set longer timeout to content-security-policy/inside-worker/dedicated-inheritance.html;

Comment 19

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d32eb09e781f62829fcad142c7002464a42b9861

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/617ee0765a32
Avoid testharness reporting unhandled promise rejections in pause-remove-from-document-networkState.html; r=annevk

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17066 for changes under testing/web-platform/tests

Comment 22

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/17066
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/McH97AogSUan1VKDu9oNQg)

Comment 23

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/617ee0765a32

Comment 24

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 25

[709922234]

pref dom.promise_rejection_events.enabled default value should be changed to true

Comment 26

[Edgar Chen [:edgar]]

Enabling on nightly only doesn't work because it will cause the test starts to fail after merged into beta or release. So we should just enable on everywhere.

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d629658891ae
Enable promise rejection event and update tests result; r=smaug

Comment 28

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d629658891ae

Comment 29

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 30

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #29)

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

As this is to enable a new feature on 69, I think we should move status-firefox67 and status-firefox68 to default ---.

Comment 31

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Release Note Request (optional, but appreciated)
[Why is this notable]: While implementing Promises, developers need to handle rejections and catch them accordingly, but sometimes they may not. This feature is useful for debugging, for general application resiliency, and for providing fallback error handling for unexpected situations.
[Affects Firefox for Android]: yes
[Suggested wording]:
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/PromiseRejectionEvent

Comment 32

[Florian Scholz (Open Web Docs)]

Announced here: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/69#JavaScript
Docs were already updated per https://bugzilla.mozilla.org/show_bug.cgi?id=1362272#c17

Compat table looks up to date to me, too: https://developer.mozilla.org/en-US/docs/Web/API/PromiseRejectionEvent#Browser_compatibility
(we don't mark this as shipping Firefox Android 69 as 68 is the last Android we've shipped per https://groups.google.com/forum/#!topic/mozilla.dev.platform/k-irJtmCcqg)

Comment 33

[Ryan VanderMeulen [:RyanVM]]

I think updating MDN is sufficient here without adding this to the Fx69 relnotes. Feel free to NI me if you feel strongly otherwise.