1525577 - Sidebar not disabled for Private Browsing

Status: RESOLVED INVALID

(WebExtensions :: General, defect)

Description

[CosminB]

Attachment: BugSidebar.png

Sidebar not disabled for Private Browsing

[Affected versions]:

• Firefox 67.0a1 (20190206095431)

[Affected platforms]:

• Win 7 64-bit
• Mac OS X 10.14.1

[Steps to reproduce]:

1.Install:
https://addons.mozilla.org/en-US/firefox/addon/sidebar_plus/?src=search
https://addons.mozilla.org/en-US/firefox/addon/gmail-mail-sidebar/?src=search
2.Make sure ‘extensions.allowPrivateBrowsingByDefault’ is set to false.
3.Click on the View option from Menu Bar.
4.Hover over the Sidebar.
5.Observe the extensions displayed in the Sidebar.

[Expected results]:

• According to Bug1516680 the extensions should be disabled in Private Browsing.

[Actual results]:

• The extensions that use sidebar are not disabled in Private Browsing.

Please see the attached video.

I did a regression window and observed that Bug 1516680 is the one that caused this regression.

Pushlog:https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d8268f8ec7d271324c09e70cf23f40b18c584240&tochange=d2bb10ec687e38b878a7512652e70cdd6d0bb2fc

Comment 1

[Shane Caraveo (:mixedpuppy)]

not a regression since that is the bug that implemented this.

I'm unable to reproduce this. Did you verify that the extensions do not have private browsing enabled in about:addons?

Comment 2

[CosminB]

You are right, it seems they were enabled for private browsing.