Open Bug 1525580 Opened 1 year ago Updated 2 months ago

Intermittent Assertion failure: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1))), at z:/build/build/src/dom/cache/FileUtils.cpp:383

Categories

(Core :: DOM: Service Workers, defect, P2)

defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned, NeedInfo)

References

Details

(Keywords: intermittent-failure, leave-open, regression, Whiteboard: [stockwell disabled])

Crash Data

Attachments

(5 files)

#[markdown(off)]
Filed by: shindli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=226473085&repo=mozilla-central

https://queue.taskcluster.net/v1/task/eGYHFxqxTFewOnJl5juGNg/runs/0/artifacts/public/logs/live_backing.log

11:59:48 INFO - PID 3804 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1549452673\appdata\local\temp\tmpqe14ak.mozrunner\runtests_leaks_7900_tab_pid700.log
11:59:48 INFO - PID 3804 | [Child 700, Main Thread] WARNING: No CID found when attempting to map contract ID: file z:/build/build/src/xpcom/components/nsComponentManager.cpp, line 744
11:59:48 INFO - PID 3804 | --DOCSHELL 000001EEC4D78800 == 0 [pid = 6740] [id = {9cdf3d16-9388-49b3-bcb3-1f953c601db8}]
11:59:48 INFO - PID 3804 | --DOMWINDOW == 3 (000001EEC8EA3400) [pid = 6740] [serial = 1] [outer = 0000000000000000] [url = http://web-platform.test:8000/fetch/corb/script-js-mislabeled-as-html.sub.html]
11:59:48 INFO - PID 3804 | --DOMWINDOW == 2 (000001EEC8EA4400) [pid = 6740] [serial = 2] [outer = 0000000000000000] [url = about:blank]
11:59:48 INFO - PID 3804 | --DOMWINDOW == 1 (000001EECAEB2800) [pid = 6740] [serial = 3] [outer = 0000000000000000] [url = about:blank]
11:59:48 INFO - PID 3804 | --DOMWINDOW == 0 (000001EECB18E400) [pid = 6740] [serial = 4] [outer = 0000000000000000] [url = http://web-platform.test:8000/fetch/corb/script-js-mislabeled-as-html.sub.html]
11:59:48 INFO - PID 3804 | [Child 2220, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file z:/build/build/src/xpcom/base/nsSystemInfo.cpp, line 116
11:59:48 INFO - PID 3804 | [Child 2220, Main Thread] WARNING: site security information will not be persisted: file z:/build/build/src/security/manager/ssl/nsSiteSecurityService.cpp, line 506
11:59:48 INFO - PID 3804 | [Parent 4428, Main Thread] WARNING: 'NS_FAILED(rv)', file z:/build/build/src/netwerk/url-classifier/UrlClassifierCommon.cpp, line 126
11:59:49 INFO - PID 3804 | ++DOMWINDOW == 3 (000001F4CB0B6000) [pid = 2220] [serial = 3] [outer = 000001F4C909D400]
11:59:49 INFO - PID 3804 | nsStringStats
11:59:49 INFO - PID 3804 | => mAllocCount: 7520
11:59:49 INFO - PID 3804 | => mReallocCount: 0
11:59:49 INFO - PID 3804 | => mFreeCount: 7520
11:59:49 INFO - PID 3804 | => mShareCount: 5483
11:59:49 INFO - PID 3804 | => mAdoptCount: 442
11:59:49 INFO - PID 3804 | => mAdoptFreeCount: 446
11:59:49 INFO - PID 3804 | => Process ID: 6740, Thread ID: 4940
11:59:49 INFO - PID 3804 | ++DOMWINDOW == 4 (000001F4CB38C800) [pid = 2220] [serial = 4] [outer = 000001F4C909D400]
11:59:49 WARNING - Traceback (most recent call last):
11:59:49 WARNING - File "Z:\task_1549452673\build\tests\web-platform\tests\tools\wptrunner\wptrunner\executors\executormarionette.py", line 604, in _run
11:59:49 WARNING - self.result = True, self.func(self.protocol, self.url, self.timeout)
11:59:49 WARNING - File "Z:\task_1549452673\build\tests\web-platform\tests\tools\wptrunner\wptrunner\executors\executormarionette.py", line 718, in do_testharness
11:59:49 WARNING - self.script_resume % format_map, async=True)
11:59:49 WARNING - File "Z:\task_1549452673\build\tests\web-platform\tests\tools\wptrunner\wptrunner\executors\executormarionette.py", line 61, in execute_script
11:59:49 WARNING - return method(script, new_sandbox=False, sandbox=None)
11:59:49 WARNING - File "Z:\task_1549452673\build\venv\lib\site-packages\marionette_driver\marionette.py", line 1822, in execute_async_script
11:59:49 WARNING - rv = self._send_message("WebDriver:ExecuteAsyncScript", body, key="value")
11:59:49 WARNING - File "Z:\task_1549452673\build\venv\lib\site-packages\marionette_driver\decorators.py", line 26, in _
11:59:49 WARNING - return func(*args, **kwargs)
11:59:49 WARNING - File "Z:\task_1549452673\build\venv\lib\site-packages\marionette_driver\marionette.py", line 764, in _send_message
11:59:49 WARNING - self._handle_error(err)
11:59:49 WARNING - File "Z:\task_1549452673\build\venv\lib\site-packages\marionette_driver\marionette.py", line 784, in _handle_error
11:59:49 WARNING - raise errors.lookup(error)(message, stacktrace=stacktrace)
11:59:49 WARNING - JavascriptException: TypeError: window.__wptrunner_process_next_event is not a function
11:59:49 WARNING - stacktrace:
11:59:49 WARNING - @Z:\task_1549452673\build\tests\web-platform\tests\tools\wptrunner\wptrunner\executors\executormarionette.py:66:1
11:59:49 WARNING - @Z:\task_1549452673\build\tests\web-platform\tests\tools\wptrunner\wptrunner\executors\executormarionette.py:61:59
11:59:49 WARNING -
11:59:49 WARNING -
11:59:49 INFO - TEST-ERROR | /fetch/corb/script-resource-with-json-parser-breaker.tentative.sub.html | took 1411ms
11:59:49 INFO - PID 3804 | 1549454389544 Marionette INFO Stopped listening on port 2828
11:59:49 INFO - PID 3804 | [Child 2220, Main Thread] WARNING: Not same origin error!: file z:/build/build/src/dom/base/nsJSEnvironment.cpp, line 443
11:59:49 INFO - PID 3804 | JavaScript error: http://www1.web-platform.test:8000/fetch/corb/resources/sniffable-resource.py?type=text/html&body=)%5D%7D%27, line 1: SyntaxError: expected expression, got ')'
11:59:49 INFO - PID 3804 | [Child 2220, Main Thread] WARNING: Not same origin error!: file z:/build/build/src/dom/base/nsJSEnvironment.cpp, line 443
11:59:49 INFO - PID 3804 | JavaScript error: http://www1.web-platform.test:8000/fetch/corb/resources/sniffable-resource.py?type=text/html&body=%7B%7D%26%26, line 1: SyntaxError: expected expression, got '&&'
11:59:49 INFO - PID 3804 | [Child 2220, Main Thread] WARNING: Not same origin error!: file z:/build/build/src/dom/base/nsJSEnvironment.cpp, line 443
11:59:49 INFO - PID 3804 | [Parent 4428, URL Classifier] WARNING: 'NS_FAILED(rv)', file z:/build/build/src/netwerk/url-classifier/AsyncUrlChannelClassifier.cpp, line 228

Component: DOM → DOM: Core & HTML
Component: DOM: Core & HTML → DOM: Service Workers

James, looks like this started to increase in failure rate with the wpt pr push here: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a9e8bb1d8a1617763205dc0ef46ec4fd663113cf&selectedJob=242277749

https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2019-04-19&endday=2019-04-26&tree=trunk&bug=1525580

Could you, please, take a look?

There are 49 total failures in the last 7 days, mostly in the last 2/3 days on

  • debug windows7-32, windows10-64, windows10-64-ccov

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242846571&repo=mozilla-inbound&lineNumber=22704

12:12:54 INFO - TEST-TIMEOUT | /service-workers/service-worker/update-after-navigation-redirect.https.html | took 180553ms
12:12:54 INFO - TEST-START | /service-workers/service-worker/update-after-oneday.https.html
12:12:54 INFO - Clearing pref dom.serviceWorkers.enabled
12:12:54 INFO - Clearing pref javascript.options.streams
12:12:54 INFO - Setting pref dom.serviceWorkers.enabled (true)
12:12:54 INFO - Setting pref dom.serviceWorkers.testUpdateOverOneDay (true)
12:12:54 INFO - Setting pref javascript.options.streams (true)
12:12:54 INFO - Closing window 352187318273
12:12:54 INFO - PID 8452 | [Child 9516, Main Thread] WARNING: '!window', file z:/build/build/src/dom/cache/CacheStorage.cpp, line 574
12:12:54 INFO - PID 8452 | [Child 9516, Main Thread] WARNING: NS_ENSURE_TRUE(global) failed: file z:/build/build/src/dom/serviceworkers/ServiceWorkerRegistrationImpl.cpp, line 106
12:12:54 INFO - PID 8452 | [Child 9516, Main Thread] WARNING: NS_ENSURE_TRUE(global) failed: file z:/build/build/src/dom/serviceworkers/ServiceWorkerRegistrationImpl.cpp, line 106
12:12:54 INFO - PID 8452 | --DOCSHELL 00000197BF989000 == 1 [pid = 9516] [id = {d14918ca-d8c6-4d2f-adb2-387336d1d203}] [url = https://web-platform.test:8443/service-workers/service-worker/resources/empty.html]
12:12:54 INFO - PID 8452 | [Child 9516, Main Thread] WARNING: '!window', file z:/build/build/src/dom/cache/CacheStorage.cpp, line 574
12:12:54 INFO - PID 8452 | [Parent 3844, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | [Child 9516, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | [Child 9516, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | [Child 9516, Main Thread] WARNING: A runnable was posted to a worker that is already shutting down!: file z:/build/build/src/dom/workers/WorkerPrivate.cpp, line 1355
12:12:54 INFO - PID 8452 | [Child 9516, Main Thread] WARNING: Failed to dispatch offline status change event!: file z:/build/build/src/dom/workers/WorkerPrivate.cpp, line 1822
12:12:54 INFO - PID 8452 | [Child 9516, Main Thread] WARNING: '!window', file z:/build/build/src/dom/cache/CacheStorage.cpp, line 574
12:12:54 INFO - PID 8452 | [Child 9516,[Parent 3844, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | DOM Worker] WARNING: '!holder->HoldWorker(aWorkerPrivate, Canceling)', file z:/build/build/src/dom/workers/WorkerRef.cpp, line 112
12:12:54 INFO - PID 8452 | [Child 9516, DOM Worker] WARNING: '!mWorkerRef', file z:/build/build/src/dom/serviceworkers/ServiceWorkerRegistrationImpl.cpp, line 870
12:12:54 INFO - PID 8452 | [GPU 2264, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | ++DOCSHELL 0000015E1C34C800 == 1 [pid = 1472] [id = {8c3706c8-7642-4258-a127-5e370f1aefc6}]
12:12:54 INFO - PID 8452 | ++DOMWINDOW == 1 (0000015E22C32020) [pid = 1472] [serial = 1] [outer = 0000000000000000]
12:12:54 INFO - PID 8452 | [GPU 2264,
12:12:54 INFO - PID 8452 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
12:12:54 INFO - PID 8452 | Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | [Child 9516, Main Thread] WARNING: NS_ENSURE_TRUE(global) failed: file z:/build/build/src/dom/serviceworkers/ServiceWorkerRegistrationImpl.cpp, line 106
12:12:54 INFO - PID 8452 | [Child 9516, DOM Worker] WARNING: '!holder->HoldWorker(aWorkerPrivate, aFailStatus)', file z:/build/build/src/dom/workers/WorkerRef.cpp, line 176
12:12:54 INFO - PID 8452 | [Child 9516, Main Thread] WARNING: NS_ENSURE_TRUE(global) failed: file z:/b[Parent 3844, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/buuild/build/sild/src/iprc/dom/serviceworkers/ServiceWorkerRegistrationImc/chromium/sprl.cpp, line 106
12:12:54 INFO - PID 8452 | c/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | ++DOMWINDOW == 2 (0000015E226EE400) [pid = 1472] [serial = 2] [outer = 0000015E22C32020]
12:12:54 INFO - PID 8452 | [Parent 3844, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | [Parent 3844, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | [Parent 3844, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
12:12:54 INFO - PID 8452 | [Parent 3844, DOMCacheThread] WARNING: 'NS_FAILED(rv)', file z:/build/build/src/dom/cache/FileUtils.cpp, line 722
12:12:54 INFO - PID 8452 | Assertion failure: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1))), at z:/build/build/src/dom/cache/FileUtils.cpp:383

Flags: needinfo?(james)
Duplicate of this bug: 1544949
Crash Signature: [@ mozilla::dom::cache::BodyDeleteFiles(mozilla::dom::cache::QuotaInfo const &,nsIFile *,nsTArray<nsID> const &)]
Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]

This one needs investigation from the DOM team; if the frequency has increased with the latest wpt update hopefully that makes the issue easier to track down :)

Flags: needinfo?(james) → needinfo?(amarchesini)
Priority: -- → P2
Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]
Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]

Joel, can you take a look at this?

Flags: needinfo?(jmaher)

I say we should disable /service-workers/service-worker/update-after-oneday.https.html:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/service-workers/service-worker/update-after-oneday.https.html.ini

probably:
os == "win" and debug
os == "win" and ccov

Flags: needinfo?(jmaher)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1574bf33c611
Disabled update-after-oneday.https.html for high frequent failures r=jmaher
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

I am a bit at a loss, but there is no other prior art showing os=="win", it is always |os == "win"|

we should give that a try, all the other syntax seems proper, as well as the spacing.

Flags: needinfo?(jmaher)
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8ffe8e990fb
Disabled update-after-oneday.https.html for high frequent failures r=jmaher
Flags: needinfo?(jmaher)

a different test is failing: /service-workers/service-worker/update-bytecheck.https.html, I suspect this will take a few rounds to disable all the problematic tests. If we do a few tests and it still fails, I would look at the test prior:

/service-workers/service-worker/update-after-navigation-redirect.https.html

Flags: needinfo?(jmaher)

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ca4bf4b58fa
disabled update-bytecheck.https.html on win qr and debug r=jmaher

Keywords: checkin-needed

This is now failing on update-missing-import-scripts.https.html based on recent logs.

Lando keeps failing because Bug 1525580 - disabled update-missing-import-scripts.https.html on win debug r=jmaher - has 2 spaces between bug and 1525580. I've tried to edit the commit but the changes are not applied in phabricator, just locally, i'm not sure why.

Flags: needinfo?(aryx.bugmail)
Attachment #9064583 - Attachment description: Bug 1525580 - disabled update-missing-import-scripts.https.html on win debug → Bug 1525580 - Disable update-missing-import-scripts.https.html on win debug.

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22dc1f7f426b
Disable update-missing-import-scripts.https.html on win debug. r=jmaher

Keywords: checkin-needed

I would say lets disable the previous test:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/service-workers/service-worker/update-after-navigation-redirect.https.html.ini

then reenable the last 3 we disabled- it seems to be every test immediately after update-after-navigation-redirect.https.html.ini is failing.

Flags: needinfo?(jmaher)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a529f87452c
Disable update-after-navigation-redirect.https.html and re-enable other tests. r=jmaher
Flags: needinfo?(aryx.bugmail)
Summary: Intermittent PID 3908 | Assertion failure: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1))), at z:/build/build/src/dom/cache/FileUtils.cpp:383 → Intermittent Assertion failure: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1))), at z:/build/build/src/dom/cache/FileUtils.cpp:383
You need to log in before you can comment on or make changes to this bug.