1525581 - Show cached data immediately on subsequent loads

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Andrei Oprea [:andreio]]

On startup we want to immediately show cached content (if it's less than a week old) and do a background fetch so that the next newtab or load will have fresh data.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4765

Comment 2

[Tim Spurway [:tspurway]]

[Tracking Requested - why for this release]:

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/ba5eb152fe23

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Want to request uplift here? Is there some way to verify the fix?

Comment 5

[Andrei Oprea [:andreio]]

Attachment: Bug 1525581 - Show Activity Stream cached data immediately on subsequent loads

Comment 6

[Andrei Oprea [:andreio]]

Added QA steps in user story.

Comment 7

[Kate Hudson :k88hudson]

Is this going to conflict with https://bugzilla.mozilla.org/show_bug.cgi?id=1525413? Does that need to land first?

Comment 8

[Kate Hudson :k88hudson]

Ok, so what you'll need to do to update this is:

1. arc patch my https://phabricator.services.mozilla.com/D19577 diff and reset your phabricator branch to that
2. In Github, cherry-pick your commit on top of my bug1525413-uplift branch (see: https://github.com/mozilla/activity-stream/compare/beta...k88hudson:bug1525413-uplift)
3. npm run builduplift and commit the new diff, update your phabricator patch against HEAD^

Ping me if you have trouble

Comment 9

[Andrei Oprea [:andreio]]

Updated the patch waiting on bug 1520258 and bug 1525413 to get uplifted.

Comment 10

[Andrei Oprea [:andreio]]

QA needed. Please let me know if there are any issues with the steps.

Comment 11

[Andrei Oprea [:andreio]]

Comment on attachment 9043314 [details]
Bug 1525581 - Show Activity Stream cached data immediately on subsequent loads

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1512725

User impact if declined

Slower user experience at startup

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

Yes

If yes, steps to reproduce

QA steps in User Story

List of other uplifts needed

Bug 1525413

Risk to taking this patch

Medium

Why is the change risky/not risky? (and alternatives if risky)

This patch already landed in Nightly and has QA steps for verification.

String changes made/needed

Comment 12

[Brahmini Nagabandi]

Attachment: QA Result : bug - 1525581 (?).png

Tested on :

FF Nightly version : 67.0a1 (2019-02-13)
OS : Mac and Windows 10 Pro

I'm getting syntax error on both OS. Have the pref settings as mentioned in QA steps.

• Set the pref browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}

I made sure to enable (via Settings) :

• Enable browser chrome and add-on debugging toolboxes
• Enable remote debugging

Is there anything I'm missing?

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9043314 [details]
Bug 1525581 - Show Activity Stream cached data immediately on subsequent loads

After discussion with k88hudson we're going to go ahead and take this for beta 8.
It shouldn't cause problems for beta users on the whole since it's behind a pref, so we're OK to verify in beta after the uplift.

Comment 14

[Brahmini Nagabandi]

QA Results : Pass

FF Nightly version : 67.0a1 (2019-02-14)
OS : Mac and Windows 10 Pro

I was able to test this after restarting browser.

Seeing the same counts and timestamps each time after every restart.

Below are attachments for Mac OS and Windows 10.

Comment 15

[Brahmini Nagabandi]

Attachment: QA Results - bug 1525581 (Mac OS).png

QA Results: Mac OS

Comment 16

[Brahmini Nagabandi]

Attachment: Windows 10 x64 2019-02-14 10-49-15.png

QA Results: Windows 10 Pro

Comment 17

[Brahmini Nagabandi]

Closing as verified.

Comment 18

[Bogdan Maris, Desktop QA]

(In reply to Brahmini Nagabandi from comment #14)

QA Results : Pass

FF Nightly version : 67.0a1 (2019-02-14)
OS : Mac and Windows 10 Pro

I was able to test this after restarting browser.

Seeing the same counts and timestamps each time after every restart.

Below are attachments for Mac OS and Windows 10.

Would you be so kind to verify the fix on 66.0b8 as well?
https://archive.mozilla.org/pub/firefox/candidates/66.0b8-candidates/build1/

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/14f5f0ae70f4

Comment 20

[Brahmini Nagabandi]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #18)

(In reply to Brahmini Nagabandi from comment #14)

QA Results : Pass

FF Nightly version : 67.0a1 (2019-02-14)
OS : Mac and Windows 10 Pro

I was able to test this after restarting browser.

Seeing the same counts and timestamps each time after every restart.

Below are attachments for Mac OS and Windows 10.

Would you be so kind to verify the fix on 66.0b8 as well?
https://archive.mozilla.org/pub/firefox/candidates/66.0b8-candidates/build1/

Tested on BETA

QA Results: Pass

Tested on :

FF Beta version : 66.0b9 (64-bit)
OS : Mac and Windows 10 Pro

• Followed QA steps as in user story
• I have set pref browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}

Works as expected.

Comment 21

[Bogdan Maris, Desktop QA]

(In reply to Brahmini Nagabandi from comment #20)

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #18)

(In reply to Brahmini Nagabandi from comment #14)

QA Results : Pass

FF Nightly version : 67.0a1 (2019-02-14)
OS : Mac and Windows 10 Pro

I was able to test this after restarting browser.

Seeing the same counts and timestamps each time after every restart.

Below are attachments for Mac OS and Windows 10.

Would you be so kind to verify the fix on 66.0b8 as well?
https://archive.mozilla.org/pub/firefox/candidates/66.0b8-candidates/build1/

Tested on BETA

QA Results: Pass

Tested on :

FF Beta version : 66.0b9 (64-bit)
OS : Mac and Windows 10 Pro

• Followed QA steps as in user story
• I have set pref browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}

Works as expected.

Thanks for the verification, removing qe-verify flag as well.