1525627 - Using import() from a Sandbox throws with NS_ERROR_OUT_OF_MEMORY

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Alexandre Poirot [:ochameau]]

I was trying to see if we could start using import() in code DevTools modules,
but I'm getting exception when trying to use import() from a privileged Sandbox:

const s = Cu.Sandbox(Services.scriptSecurityManager.getSystemPrincipal());
Cu.evalInSandbox("import('https://cdn.jsdelivr.net/gh/lodash/lodash/camelCase.js')", s);

=> (NS_ERROR_OUT_OF_MEMORY) [nsIXPCComponents_Utils.evalInSandbox]" nsresult: "0x8007000e (NS_ERROR_OUT_OF_MEMORY)"

Note that the same applies to Sandbox with a content principal:

const s = Cu.Sandbox("http://jsdelivr.net")
Cu.evalInSandbox("import('https://cdn.jsdelivr.net/gh/lodash/lodash/camelCase.js')", s);

And it also fails if I'm trying to load a ES Modules from a resource URI:

const s = Cu.Sandbox(Services.scriptSecurityManager.getSystemPrincipal());
Cu.evalInSandbox("var x = import('resource://devtools/shared/event-emitter.jsm')", s)

(I added this event-emitter.jsm module, it doesn't exists in m-c)

Comment 1

[Alexandre Poirot [:ochameau]]

Note that, this is not a must-have feature.

You may as well say import() is not planned to work in Sandboxes.
It's just that I was hitting this exception while looking into bug 1525652.

Comment 2

[Jon Coppeard (:jonco)]

Modules are not implemented in the context of a Sandbox. However this should be reporting a more useful error than NS_ERROR_OUT_OF_MEMORY.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bug1525627-loader-check

Patch to report an error if we can't find a ScriptLoader for the current context.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95fd39d659bc
Report an error if there's no ScriptLoader for the current context. r=baku

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/95fd39d659bc