Closed Bug 1525642 Opened 8 months ago Closed 6 months ago

Make WPT css/css-transforms/transform3d-matrix3d-005.html pass on windows

Categories

(Core :: Graphics: WebRender, defect, P2)

Other Branch
defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox67 --- fixed
firefox68 --- fixed

People

(Reporter: kats, Assigned: Gankra)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Priority: -- → P4
Assignee: nobody → dmalyshau
Blocks: wr-67
No longer blocks: stage-wr-trains
Priority: P4 → P3
Priority: P3 → P2

This is fairly straightforward - handling transformations (non-preserve3d) with W != 1. It's easy to make a wrench reftest and debug from there.

Assignee: dmalyshau → a.beingessner
Blocks: wr-68
No longer blocks: wr-67
Keywords: checkin-needed

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4febe6f32b23
ensure that w~=1 when assuming a transform is just a translation. r=gw

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Comment on attachment 9057673 [details]
Bug 1525642 - ensure that w~=1 when assuming a transform is just a translation.

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: Correctness issues with 3d transforms when using WebRender
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple patch with good tests. Only affects WebRender
  • String changes made/needed:
Attachment #9057673 - Flags: approval-mozilla-beta?

Comment on attachment 9057673 [details]
Bug 1525642 - ensure that w~=1 when assuming a transform is just a translation.

Low risk correctess issue with WebRender and we ship our first version of WebRender in 67. Uplift approved for 67 beta 11, thanks!

Attachment #9057673 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.