Improve logging in MoofPaser since changes to support cbcs
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: bryce, Assigned: bryce)
Details
Attachments
(3 files)
We could benefit from more logging in the MoofParser following the changes from bug 1519617. This is also an opportunity to log instead of asserting for certain conditions that can theoretically occur, such as multiple encrypted sample description entries.
|
Assignee | |
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8fbe04aeb14caedca3241e52819f77169dd9d28
|
|
Assignee | |
Comment 2•5 years ago
|
||
- Use different log levels in MoofParser. Generally Error is used for out of
memory, while warnings are used for bad mp4s. - Add some new logs for parsing sample description entries.
- Add logs for when we can't find a Moof or fail to read a Moov.
- Have logs be more specific for the Box they're in where possible rather than
just log 'Moof'. E.g., when parsing the stsd box, we now log against that box,
not 'Moof'. - Log instead of asserting if we're given multiple encrypted sample description
entries. This is valid per the spec, and can happen (though we don't expect
it), so we shouldn't assert.
|
|
Assignee | |
Comment 3•5 years ago
|
||
The MoofParser didn't have logging on its normal code paths. This patch
implements such logging, covering entry and exit to many functions. Such verbose
logs are helpful for diagnosing failures and the specific file structure leading
to such failures. This should help improve our debugging experience if we can
get logs from end users which is particularly useful for cases where they can't
provide us with media due to geoblocking/proprietary media issues.
Depends on D19020
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D19021
|
||
Updated•5 years ago
|
Pushed by bvandyk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd4a1f69d272 Improve logging in MoofParser. r=jya https://hg.mozilla.org/integration/autoland/rev/081476483f25 Add debug logging to MoofParser. r=jya https://hg.mozilla.org/integration/autoland/rev/cf6f7992935c Remove aTkhd arg from MoofParser::ParseMdia as it is unused. r=jya
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bd4a1f69d272
https://hg.mozilla.org/mozilla-central/rev/081476483f25
https://hg.mozilla.org/mozilla-central/rev/cf6f7992935c
Description
•