Closed Bug 1525682 Opened 9 months ago Closed 8 months ago

Add back the telemetry probe monitoring the error messages issued by SpiderMonkey.

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: nbp, Assigned: nchevobbe)

References

Details

Attachments

(2 files)

Bug 1381834 removed the code which was collecting [1] the telemetry reported by are-we-documented-yet [2], which was used to document on MDN the most common error messages reported to JavaScript developers.

[1] https://hg.mozilla.org/mozilla-central/rev/1e71c12ebd74#l414.1452
[2] https://nbp.github.io/arewedocumentedyet/

It seems that the best place to add the telemetry back would be to add it directly as part of the file which is listing all the code which are being monitored, which is errordocs.js , within the GetURL function [1].

However, I could not find any example of code which is doing telemetry within the devtools/server directory, I can only find examples of telemetry within the devtools client, which I presume is too late for matching the error messages keys.

[1] https://searchfox.org/mozilla-central/source/devtools/server/actors/errordocs.js#1351381834

Flags: needinfo?(nchevobbe)

I think we can add it in the client code, I'll have a look today

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Flags: needinfo?(nchevobbe)

This will be used in telemetry events. Also,
we add errorMessageName in evaluation result packets.
Stubs are generated so they include the new property.

This patch adds the DEVTOOLS_JAVASCRIPT_ERROR_DISPLAYED telemetry probe
back. It existed in the old frontend and was removed when the old
frontend was removed.
A test is added to ensure this is working correctly (and that we won't
delete it by mistake again in the future).

Depends on D18925

Priority: -- → P1
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/826603df2956
Add `errorMessageName` in ConsoleMessage; r=bgrins.
https://hg.mozilla.org/integration/autoland/rev/59f64d14a31d
Add back the telemetry probe monitoring the error messages issued by SpiderMonkey. r=miker
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.