Closed Bug 1525688 Opened 5 years ago Closed 5 years ago

Running jstests without activating virtual env for build environment fails, and bootstrap.py fails

Categories

(Firefox Build System :: Bootstrap Configuration, defect, P1)

defect

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file, 1 obsolete file)

jstests.py can be executed without activating virtualenv inside obj-* directory,
(that's not tested in automation, but JS devs use that way),
and with such configuration the following import fails.

https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/python/mozboot/mozboot/util.py#9

moving it after if not srcdir: return state_dir lines work.

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED

looks like, this also affects running standalone bootstrap.py

Summary: Running jstests without activating virtual env for build environment fails → Running jstests without activating virtual env for build environment fails, and bootstrap.py fails

This blocks newcomer from setting up environment.
Should be fixed quickly.

Priority: -- → P1
Attachment #9041918 - Flags: review?(mh+mozilla)
Attachment #9041918 - Flags: review?(mh+mozilla) → review?(nalexander)
Comment on attachment 9041918 [details] [diff] [review]
Lazily import mozbuild.base in mozboot/util.py.

looks like phabricator is now working.
moving to there.
Attachment #9041918 - Attachment is obsolete: true
Attachment #9041918 - Flags: review?(nalexander)
Attachment #9042123 - Attachment description: Bug 1525688 - Lazily import mozbuild.base in mozboot/util.py. r?nalexander → Bug 1525688 - Lazily import mozbuild.base in mozboot/util.py. r=ahal
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/bd2e27b25f57
Lazily import mozbuild.base in mozboot/util.py. r=ahal
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: