Closed
Bug 1525688
Opened 5 years ago
Closed 5 years ago
Running jstests without activating virtual env for build environment fails, and bootstrap.py fails
Categories
(Firefox Build System :: Bootstrap Configuration, defect, P1)
Firefox Build System
Bootstrap Configuration
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file, 1 obsolete file)
jstests.py can be executed without activating virtualenv inside obj-* directory,
(that's not tested in automation, but JS devs use that way),
and with such configuration the following import fails.
moving it after if not srcdir: return state_dir
lines work.
Assignee | ||
Comment 1•5 years ago
|
||
testing patch
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42686144ec592fcad89d459f3118dbe1e9eee315
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•5 years ago
|
||
looks like, this also affects running standalone bootstrap.py
Assignee | ||
Updated•5 years ago
|
Summary: Running jstests without activating virtual env for build environment fails → Running jstests without activating virtual env for build environment fails, and bootstrap.py fails
Assignee | ||
Comment 3•5 years ago
|
||
This blocks newcomer from setting up environment.
Should be fixed quickly.
Priority: -- → P1
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Attachment #9041918 -
Flags: review?(mh+mozilla)
Assignee | ||
Updated•5 years ago
|
Attachment #9041918 -
Flags: review?(mh+mozilla) → review?(nalexander)
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9041918 [details] [diff] [review] Lazily import mozbuild.base in mozboot/util.py. looks like phabricator is now working. moving to there.
Attachment #9041918 -
Attachment is obsolete: true
Attachment #9041918 -
Flags: review?(nalexander)
Assignee | ||
Comment 7•5 years ago
|
||
Updated•5 years ago
|
Attachment #9042123 -
Attachment description: Bug 1525688 - Lazily import mozbuild.base in mozboot/util.py. r?nalexander → Bug 1525688 - Lazily import mozbuild.base in mozboot/util.py. r=ahal
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/bd2e27b25f57 Lazily import mozbuild.base in mozboot/util.py. r=ahal
Comment 9•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•