1525695 - ReferenceError: executeSoon is not defined- irc.js:1164:7

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Magnus Melin [:mkmelin]]

I'm getting an error

ReferenceError: executeSoon is not defined[Learn More] irc.js:1164:7

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1525695-fix-executeSoon.patch

I hope, it's only missing in this file. A lot other files have it defined: https://searchfox.org/comm-central/search?q=executeSoon&case=false&regexp=false&path=

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1525695_irc_refs.patch

Fixing the imports, and with this IRC seems to be working again.

I have to say, especially the TextboxSize usage looks wrong, working like some kind of global settings getter. That could be fixed in a later bug though.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 9041907 [details] [diff] [review]
bug1525695_irc_refs.patch

Review of attachment 9041907 [details] [diff] [review]:
-----------------------------------------------------------------

jsProtoHelper.jsm also needs l10nHelper from imXPCOMUtils.jsm

::: chat/components/src/imAccounts.js
@@ +6,5 @@
>    EmptyEnumerator,
>    nsSimpleEnumerator,
>    XPCOMUtils,
> +  setTimeout,
> +  clearTimeout,

This file also uses executeSoon.

::: mail/components/im/content/imAccounts.js
@@ +8,5 @@
>  /* globals statusSelector */
>  
>  var { Services } = ChromeUtils.import("resource:///modules/imServices.jsm", null);
>  var { fixIterator } = ChromeUtils.import("resource:///modules/iteratorUtils.jsm");
> +var { setTimeout, clearTimeout } = ChromeUtils.import("resource:///modules/imXPCOMUtils.jsm");

Was there any error related to missing these functions? Normally they are already part of the window object in that case, as this is loaded in a xul window.

Comment 4

[Magnus Melin [:mkmelin]]

Right, I think I added those since I first thought the error was from the other imAccounts.js file (quite confusing we have two of same name). Apparently it's not needed.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: bug1525695_irc_refs.patch

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 9042020 [details] [diff] [review]
bug1525695_irc_refs.patch

Review of attachment 9042020 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: bug1525695_irc_refs.patch

For checkin.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b8273f79234e
fix a bunch of missing imports in IRC and IM related code. r=florian