ReferenceError: executeSoon is not defined- irc.js:1164:7
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
(Keywords: regression)
Attachments
(1 file, 3 obsolete files)
6.53 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
I'm getting an error
ReferenceError: executeSoon is not defined[Learn More] irc.js:1164:7
Comment 1•2 years ago
|
||
I hope, it's only missing in this file. A lot other files have it defined: https://searchfox.org/comm-central/search?q=executeSoon&case=false®exp=false&path=
Assignee | ||
Comment 2•2 years ago
|
||
Fixing the imports, and with this IRC seems to be working again.
I have to say, especially the TextboxSize usage looks wrong, working like some kind of global settings getter. That could be fixed in a later bug though.
Updated•2 years ago
|
Updated•2 years ago
|
Comment 3•2 years ago
|
||
Comment on attachment 9041907 [details] [diff] [review] bug1525695_irc_refs.patch Review of attachment 9041907 [details] [diff] [review]: ----------------------------------------------------------------- jsProtoHelper.jsm also needs l10nHelper from imXPCOMUtils.jsm ::: chat/components/src/imAccounts.js @@ +6,5 @@ > EmptyEnumerator, > nsSimpleEnumerator, > XPCOMUtils, > + setTimeout, > + clearTimeout, This file also uses executeSoon. ::: mail/components/im/content/imAccounts.js @@ +8,5 @@ > /* globals statusSelector */ > > var { Services } = ChromeUtils.import("resource:///modules/imServices.jsm", null); > var { fixIterator } = ChromeUtils.import("resource:///modules/iteratorUtils.jsm"); > +var { setTimeout, clearTimeout } = ChromeUtils.import("resource:///modules/imXPCOMUtils.jsm"); Was there any error related to missing these functions? Normally they are already part of the window object in that case, as this is loaded in a xul window.
Assignee | ||
Comment 4•2 years ago
|
||
Right, I think I added those since I first thought the error was from the other imAccounts.js file (quite confusing we have two of same name). Apparently it's not needed.
Assignee | ||
Comment 5•2 years ago
|
||
Comment 6•2 years ago
|
||
Comment on attachment 9042020 [details] [diff] [review] bug1525695_irc_refs.patch Review of attachment 9042020 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Assignee | ||
Comment 7•2 years ago
|
||
For checkin.
Assignee | ||
Updated•2 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b8273f79234e
fix a bunch of missing imports in IRC and IM related code. r=florian
Updated•2 years ago
|
Description
•