1525698 - Make WPT css/CSS2/ui/outline-{,color,style,width}-applies-to-00{5,6}.xht and css/css-ui/outline-013.html pass on windows

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

The following WPT reftests all seem to fail on windows with some red outline visible:

! /css/CSS2/ui/outline-applies-to-005.xht
! /css/CSS2/ui/outline-applies-to-006.xht
! /css/CSS2/ui/outline-color-applies-to-005.xht
! /css/CSS2/ui/outline-color-applies-to-006.xht
! /css/CSS2/ui/outline-style-applies-to-005.xht
! /css/CSS2/ui/outline-style-applies-to-006.xht
! /css/CSS2/ui/outline-width-applies-to-005.xht
! /css/CSS2/ui/outline-width-applies-to-006.xht

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Also css/css-ui/outline-013.html is another outline-related one.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Kats, do you think we need to worry about this for 67?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

This does look like a legitimate failure, and doesn't look like it would be too hard to fix. CSS outline properties on display:table-column and display:table-column-group are apparently supposed to be ignored but are not. I think it's worth fixing but I suspect we're not going to hit this often in the wild since authors tend not to include CSS outlines on elements that aren't going to render them. Assigning to myself to investigate.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Ugh. The way this works with WR off is that we create the nsDisplayOutline, then try to paint it. When we go to create the border renderer, we fail this check and return Nothing, and therefore paint nothing. The reason the check fails is because the dirty rect is different with WR off vs WR on. With WR off, the dirty rect is the same as the inner rect (which incidentally, we get from here after triggering an NS_ERROR). With WR on, the dirty rect is the whole content area and so is not contained inside the inner rect.

Really I think we should skip creating the nsDisplayOutline entirely if the display style of the frame is table-column or table-column-group.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=b02b8f43cc5a83e7ee99589becb00fa0e59b14ba

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1525698 - Don't generate outlines for table-column or table-column-group elements. r?emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7c00b62990f
Don't generate outlines for table-column or table-column-group elements. r=emilio

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a7c00b62990f

Comment 9

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #3)

I suspect we're not going to hit this often in the wild since authors tend not to include CSS outlines on elements that aren't going to render them.

Based on this I don't think this is worth uplifting to 67.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16525 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged