1525727 - Change network.cookie.cookiebehavior pref to 4 in release and late beta

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Tanvi Vyas[:tanvi]]

Right now, network.cookie.cookiebehavior is set to 4 for early beta and nightly:
https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/browser/app/profile/firefox.js#1537
A value of 4 means that third party tracking cookies are blocked. The pref is set to 0 in release, which means no cookies are blocked.

This bug is to change the pref for Firefox 66 so that it is set to 4 by default in release and late betas, in addition to early beta and nightly.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1525727 - CookieBehavior = 4, by default, r?ehsan

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 9042225 [details]
Bug 1525727 - CookieBehavior = 4, by default, r?ehsan

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

We would like to have cookieBehavior set 4, by default in order to enable cookie-restriction project.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

This feature is well tested.

String changes made/needed

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f7b5792623ad
https://hg.mozilla.org/integration/autoland/rev/f7b5792623ad19d6992e45f3c0ac0db891cc1b28

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9042225 [details]
Bug 1525727 - CookieBehavior = 4, by default, r?ehsan

Let's uplift for beta 7 since that's when we're ending EARLY_BETA_OR_EARLIER.

Comment 5

[(no longer active)]

Comment on attachment 9042225 [details]
Bug 1525727 - CookieBehavior = 4, by default, r?ehsan

We are not going to uplift this any more (not sure why).

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Noted! I also got email from Tony about this. Ehsan, thanks for clearing the approval flag.

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26c4e662c4fa
Backout changeset f7b5792623ad because we're not ready to ship yet

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Guessing this should have been reopened:
https://hg.mozilla.org/mozilla-central/rev/26c4e662c4fa

Comment 9

[Tony Cinotto [:tcinotto] (UTC-8)]

Uplift not needed at this point. Will update bug in future if needed.

Comment 10

[(no longer active)]

WONTFIX may better reflect what actually happened here: no patch ultimately landed here.

Comment 11

[Tanvi Vyas[:tanvi]]

Reopening. Can we land this now and uplift to 69 beta? Ehsan, would you be able to take care of it?

Comment 12

[(no longer active)]

Yes.

Comment 13

[(no longer active)]

Attachment: Bug 1525727 - Enable blocking access to storage from third-party tracking resources by default

Comment 14

[(no longer active)]

Comment on attachment 9082483 [details]
Bug 1525727 - Enable blocking access to storage from third-party tracking resources by default

Beta/Release Uplift Approval Request

• User impact if declined: Existing desktop users wouldn't be protected from many of the existing privacy invasions that are common-place on the web, known as cross-site tracking. This approval is requested in order to enable Enhanced Tracking Protection for all of our desktop users by default in Firefox 69.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This feature has been undergoing extensive automated and manual testing since around Firefox 63.
• String changes made/needed: None

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3550b52cb5f2
Enable blocking access to storage from third-party tracking resources by default

Comment 16

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3550b52cb5f2

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9082483 [details]
Bug 1525727 - Enable blocking access to storage from third-party tracking resources by default

Enables ETP by default for Fx69. Approved for 69.0b11.

Comment 18

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/6827fee2cf35