1525732 - Merges to mozilla-central mess up phabricator revisions

Status: RESOLVED FIXED

(Conduit :: General, enhancement)

Description

[Mike Hommey [:glandium]]

The following scenario can be quite frustrating:

• normal phabricator workflow, up to landing with lando.
• get your patch backed out.
• figure out what the problem was, and upload a new patch (after manually reopening everything in the stack if you had a stack, which is frustrating on itself, but I know there's already a bug about that)
• you made enough changes that it needs a new review, so you set things for a review.
• unfortunately, the reviewers are not in the same time zone, so it takes some time before they do review
• in the meanwhile, the initial landing and the backout are merged to central.
• the merges update the revision, which now:
  • doesn't present the right patch anymore, so reviewers would look at the wrong patch
  • is associated with the wrong repo, so it can't be autolanded anymore
  • is closed again, so you have to reopen everything again.

That happened to me once, and since then, I've known to either wait for the landing+backout to be merged before touching anything. Or to ensure it will be reviewed before a merge happens. That still makes things harder than they should be.

Comment 1

[Steven MacLeod [:smacleod]]

I have disabled auto-closing from commits that appear in mozilla-unified[1], which should make things a lot better in the mean time. Still needs more investigation fixing this in Bug 1515378.

[1] https://phabricator.services.mozilla.com/source/mcu/