Closed Bug 1525740 Opened 2 years ago Closed 2 years ago

Visual artifacts in add-on menu with webrender enabled on mac

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: bpitts, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files, 2 obsolete files)

With webrender enabled, when I click the lastpass button the menu that appears has visual artifacts (e.g. blue bars, scrambled text) that change as I mouse over different entries.

When I disable webrender, the problem goes away.

I'm running the latest nightly on OS X on a macbook pro.

I believe this is a regression.

Priority: -- → P2

Turning off picture caching fixes the issue. Kats thinks this is probably a regression caused by bug 1524385 in combination with picture caching.

Also this seems to only show up on Mac

Priority: P2 → P3
Blocks: 1524385
Summary: Visual artifacts in Lastpass menu with webrender enabled → Visual artifacts in add-on menu with webrender enabled

I can confirm enabling webrender but disabling picture caching fixes the issue for me.

Summary: Visual artifacts in add-on menu with webrender enabled → Visual artifacts in add-on menu with webrender enabled on mac intel
Assignee: nobody → jmuizelaar
Attachment #9041989 - Attachment is obsolete: true

Comment on attachment 9041990 [details]
Bug 1525740. Disable picture caching on popups

This patch doesn't work because we still end up with picture caching turned on inside the Iframe

Attachment #9041990 - Attachment is obsolete: true

The existing picture caching code in WR assumes that the tiles are being
drawn into the main framebuffer. This is true to the main content frame,
however it's not the case for all popup windows. In the case of popup
windows on mac, they have a rounded rect clip, which results in a surface
being used. This breaks some assumptions in the picture caching code.

The long term fix involves supporting picture caching on surfaces. However,
we don't want picture caching on for non-content windows anyway (due to
wasting texture memory), so for now we will simply disable picture cache
composite modes if they are being drawn on a non-root surface.

Summary: Visual artifacts in add-on menu with webrender enabled on mac intel → Visual artifacts in add-on menu with webrender enabled on mac
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f526887aa3ae
Visual artifacts in add-on menu with webrender enabled on mac intel. r=jrmuizel
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Given the comments in bug 1524385 about uplifting to 66, setting the status for 66 to affected here as well.

QA Whiteboard: [qa-67b-p2]
Regressions: 1554502
You need to log in before you can comment on or make changes to this bug.