Add WPT for Animation methods not flushing
Categories
(Core :: DOM: Animation, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: birtles, Assigned: birtles)
References
()
Details
Attachments
(3 files)
In bug 1524480 I want to make Animatable.animate() not flush style. This will be specified in issue 3613.
I would like to split out making the WPT for that behavior into this separate bug since it involves a bit more investigation and I would like to start the review process for bug 1524480 (since I suspect it will take a few iterations and I would like to give it as much bake time as possible too).
|
Assignee | |
Comment 1•5 years ago
|
||
As requested in bug 1524480 I've been spending quite a bit of time on this so I guess it will end up being rolled into that bug after all.
So far I've been taking the approach of adding a separate test for just about every interface member. However, I guess the spec text for this will take the form of edits to the section on Model Liveness. So perhaps I should just convert the tests to a single one called web-animations/interfaces/model-liveness/style-change-events.html that loops over all the members/methods? The main trouble with that is it will be easy to forget to extend that when we add a new member.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Actually, I think I can probably write the test such that it enumerates each of the properties on an Animation or KeyframeEffect and checks that we haven't failed to test any.
|
|
Assignee | |
Comment 3•5 years ago
|
||
This is just for posterity. I'm currently working on a more unified approach.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
Proposed spec text: https://github.com/w3c/csswg-drafts/pull/3650
|
|
Assignee | |
Comment 6•5 years ago
|
||
In the next patch in this series, we will add another test to
web-animations/interfaces/Document/getAnimations.html. Doing so would cause an
existing async_test to fail since it will affect the result of
Document.getAnimations() because async_tests run in parallel. To avoid that,
this patch converts the async_test to a promise_test since promise_tests, unlike
async_tests, wait for the previous promise_tests to finish before running.
|
|
Assignee | |
Comment 7•5 years ago
|
||
Issue: https://github.com/w3c/csswg-drafts/issues/3613
Corresponding spec change: https://github.com/w3c/csswg-drafts/commit/78dc281b2c8454d763dd3d4cef728cbe4a300256
This patch also rewrites one async test in
web-animations/interfaces/Document/getAnimations.html as a promise_test to make
it independent of the other tests (since promise_tests, unlike async_tests, wait
for the previous promise_tests to finish before running).
Depends on D20240
|
|
Assignee | |
Comment 8•5 years ago
|
||
Pushed by bbirtles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0858ebbb3a90 Convert async_test in Document/getAnimations.html to a promise_test; r=hiro https://hg.mozilla.org/integration/autoland/rev/0738638178a9 Add web-platform-tests for style flushing behavior from Web Animations API; r=hiro
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15478 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0858ebbb3a90
https://hg.mozilla.org/mozilla-central/rev/0738638178a9
|
|
Assignee | |
Comment 13•5 years ago
|
||
(In reply to Web Platform Test Sync Bot from comment #11)
Upstream web-platform-tests status checks passed, PR will merge once commit
reaches central.
Something seemed to get stuck here so James merged this for us manually.
Description
•