Closed
Bug 1525858
Opened 5 years ago
Closed 5 years ago
Change app update tests to use AppConstants and mozinfo where possible instead of the preprocessed test file
Categories
(Toolkit :: Application Update, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(1 file)
This will make the tests more consistent with other tests in the repo
|
Assignee | |
Comment 1•5 years ago
|
||
Removes INSTALL_LOCALE (@AB_CD@) since it is no longer used
Replaces MOZ_APP_NAME (@MOZ_APP_NAME@) with AppConstants.MOZ_APP_NAME
Replaces IS_WIN, IS_MACOSX, and IS_UNIX with values available from AppConstants.platform
Replaces BIN_SUFFIX with mozinfo.bin_suffix
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bfc4490bedbd Use AppConstants and mozinfo where possible instead of the preprocessed test file. r=mhowell
|
||
Comment 3•5 years ago
•
|
||
Wrong changeset got backedout, relanded it. Sorry rstrong.
Flags: needinfo?(robert.strong.bugs)
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/731773b839bb Backed out changeset bfc4490bedbd for xpcfailures in uriloader/exthandler/tests/unit/test_handlerService.js CLOSED TREE
Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c3b09d5cadd Use AppConstants and mozinfo where possible instead of the preprocessed test file. r=mhowell
|
|
||
Updated•5 years ago
|
Flags: needinfo?(robert.strong.bugs)
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•