Could the FILES_PER_UNIFIED_FILES setting inherit its value from parent directories?

RESOLVED FIXED in Firefox 67

Status

enhancement
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

({in-triage})

Trunk
mozilla67

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

5 months ago

I've had to push two follow-up fixes to a busted inbound tree because of non-unified build. The first one was because I didn't try FILES_PER_UNIFIED_FILES=1 in js/src/moz.build; fine. But the second one should not have happened: it is because now every subdirectory of js/src/ has its own moz.build file with its own FILES_PER_UNIFIED_FILES variable. So now, to test non-unified compilation, we need to change N+1 moz.build files where N is the number of subdirectories with their own moz.build files.

Instead, could we just have the subdirectories inherit the FILES_PER_UNIFIED_FILES variable from the parent dir? That would make it easier to test non-unified build.

(Since my goal is really to make non-unified build testing easier, anything that goes in that direction would be helpful too, independently of the chosen solution)

export in js/src/moz.build might be able to be used for this.

Assignee

Comment 2

4 months ago

Before this patch, changing FILES_PER_UNIFIED_FILES in the directory would
require changes to all the files that defined the sandbox variable, which is
a bit misleading. Exporting the variable prevents this, and it is safe to use
because it doesn't escape the scope of the js/src build directory.

Comment 4

4 months ago
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1bb3f6cdfa73
Export FILES_PER_UNIFIED_FILES in js/src/moz.build to avoid redefining it; r=froydnj
https://hg.mozilla.org/integration/autoland/rev/9b872b266b2e
Move ENABLE_WASM_CRANELIFT build test in the wasm mozbuild; r=tcampbell

Comment 5

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → bbouvier
You need to log in before you can comment on or make changes to this bug.