Dark Mode Message text fix
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | verified |
People
(Reporter: pdahiya, Assigned: pdahiya)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
Fix dark mode message type to say "doesn't"
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Comment 3•5 years ago
|
||
This is bug work early in the nightly cycle so I don't think it needs tracking for 67 but given that there is a string change, CCing flod to make sure there is no l10n impact. Thanks.
Comment 4•5 years ago
|
||
(In reply to Pascal Chevrel:pascalc from comment #3)
This is bug work early in the nightly cycle so I don't think it needs tracking for 67 but given that there is a string change, CCing flod to make sure there is no l10n impact. Thanks.
Thanks. There are no string changes, the message is hard-coded in English per
https://github.com/mozilla/activity-stream/pull/4750#discussion_r252773454
Comment 5•5 years ago
|
||
I have verified that this issue is no longer reproducible with the Firefox Nightly build from 02/09/2019 (67.0a1 Build ID - 20190209214755) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Meanwhile, the behavior has been changed and this issue is no longer applicable because the latest Firefox Beta (67.0b9 - 20190408123043) supports the dark theme.
Updated•5 years ago
|
Description
•