1525937 - Remove unnecessary tabindex="0" from about:addons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Mark Striemer [:mstriemer]]

There are a bunch of elements that have tabindex="0" but aren't actionable. This isn't helpful and causes some other accessibility issues (see bug 1525569 comment 7).

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1525937 - Remove unnecessary tabindex="0"s from about:addons r?Jamie

Comment 2

[James Teh [:Jamie]]

Marking as regression because even though this attribute was present before, it had no effect until bug 1506787 landed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58da6f9e6cb3
Remove unnecessary tabindex="0"s from about:addons r=Jamie,jaws

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/58da6f9e6cb3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 6

[Mark Striemer [:mstriemer]]

Comment on attachment 9042192 [details]
Bug 1525937 - Remove unnecessary tabindex="0"s from about:addons r?Jamie

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1506787

User impact if declined

There are empty, hidden elements that must be tabbed through when using keyboard navigation.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Only removes tabindex from elements that have no function when being focused.

String changes made/needed

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9042192 [details]
Bug 1525937 - Remove unnecessary tabindex="0"s from about:addons r?Jamie

Additional fix for keyboard navigation. Looks straightforward, no one wants to tab through all of that. Let's uplift for beta 8.

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7e0d528168b3