Closed Bug 1525937 Opened 1 year ago Closed 1 year ago

Remove unnecessary tabindex="0" from about:addons

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- wontfix
firefox66 --- fixed
firefox67 --- fixed

People

(Reporter: mstriemer, Assigned: mstriemer)

References

Details

(Keywords: access, regression)

Attachments

(1 file)

There are a bunch of elements that have tabindex="0" but aren't actionable. This isn't helpful and causes some other accessibility issues (see bug 1525569 comment 7).

Marking as regression because even though this attribute was present before, it had no effect until bug 1506787 landed.

Keywords: access
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58da6f9e6cb3
Remove unnecessary tabindex="0"s from about:addons r=Jamie,jaws
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(mstriemer)

Comment on attachment 9042192 [details]
Bug 1525937 - Remove unnecessary tabindex="0"s from about:addons r?Jamie

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1506787

User impact if declined

There are empty, hidden elements that must be tabbed through when using keyboard navigation.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Only removes tabindex from elements that have no function when being focused.

String changes made/needed

Flags: needinfo?(mstriemer)
Attachment #9042192 - Flags: approval-mozilla-beta?

Comment on attachment 9042192 [details]
Bug 1525937 - Remove unnecessary tabindex="0"s from about:addons r?Jamie

Additional fix for keyboard navigation. Looks straightforward, no one wants to tab through all of that. Let's uplift for beta 8.

Attachment #9042192 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.