Closed Bug 1525955 Opened 7 months ago Closed 6 months ago

Cleanup a bit after bug 1525371, and shrink a bit ComputedStyle.

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

Jonathan made me feel bad when growing nsIFrame in that bug, so hopefully shrinking ComputedStyle another word will make up for it :)

This is more consistent with what the Rust bits of the style system do, and
removes a pointer from ComputedStyle which is always nice.

This also aligns the Rust bits with the C++ bits re. not treating xul pseudos as
anonymous boxes. See the comment in nsTreeStyleCache.cpp regarding those.

Can't wait for XUL trees to die.

Depends on D19001

Keywords: leave-open
Attachment #9042176 - Attachment description: Bug 1525955 - Cleanup a bit after bug 1525371. r=#style → Bug 1525955 - Cleanup a bit after bug 1525371.

Thanks for doing this.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fc71d46c09a
Include anon boxes in CSSPseudoElementType, to remove ComputedStyle::mPseudoTag. r=heycam
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.