Closed
Bug 1525955
Opened 5 years ago
Closed 5 years ago
Cleanup a bit after bug 1525371, and shrink a bit ComputedStyle.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
Jonathan made me feel bad when growing nsIFrame in that bug, so hopefully shrinking ComputedStyle another word will make up for it :)
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
This is more consistent with what the Rust bits of the style system do, and
removes a pointer from ComputedStyle which is always nice.
This also aligns the Rust bits with the C++ bits re. not treating xul pseudos as
anonymous boxes. See the comment in nsTreeStyleCache.cpp regarding those.
Can't wait for XUL trees to die.
Depends on D19001
|
|
Assignee | |
Updated•5 years ago
|
Keywords: leave-open
|
||
Updated•5 years ago
|
Attachment #9042176 -
Attachment description: Bug 1525955 - Cleanup a bit after bug 1525371. r=#style → Bug 1525955 - Cleanup a bit after bug 1525371.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/649d3fa374ff Cleanup a bit after bug 1525371. r=jwatt
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
|
||
Comment 5•5 years ago
|
||
Thanks for doing this.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1fc71d46c09a Include anon boxes in CSSPseudoElementType, to remove ComputedStyle::mPseudoTag. r=heycam
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•