1525966 - Error message missing "Error while detaching the browsing context target front: undefined"

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

At https://searchfox.org/mozilla-central/rev/490ab7f9b84570573a49d7fa018673ce0d5ddf22/devtools/shared/fronts/targets/browsing-context.js#155 we are trying to display errors occurring during the detach.

However sometimes e is a String and not an error object. Therefore,
Error while detaching the browsing context target front: ${e.message} will log "undefined".

Example STRs:

• open a tab on any url
• open about:debugging
• inspect the tab opened in step 1
• close about:devtools toolbox

AR: In the logs you will see:

console.warn: "Error while detaching the browsing context target front: undefined"

ER: Instead of undefined, we should have the error message. Here for instance:

Protocol error (noSuchActor): No such actor for ID: server1.conn0.child19/frameTarget1

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1525966 - Reject Error object instead of string in DevTools Front:onPacket

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1525966 - Support string errors when detach fails in target fronts

Depends on D55829

In case other rejects are still using strings instead of error objects.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ff967efc6d6
Reject Error object instead of string in DevTools Front:onPacket r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/06ca873edb4c
Support string errors when detach fails in target fronts r=nchevobbe

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1525966) for causing devtools failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/40a1f78a299cd6a24267a3d0020797dad3141fff

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&fromchange=06ca873edb4c9eb7d09fbe62e93aeb43c90fab45&tochange=40a1f78a299cd6a24267a3d0020797dad3141fff&searchStr=%28dt&group_state=expanded

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280283787&repo=autoland&lineNumber=2026
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280283788&repo=autoland&lineNumber=5297

Comment 5

[Julian Descottes [:jdescottes]]

Sorry about that! Of course tests relied on the error being a string!

Comment 6

[Julian Descottes [:jdescottes]]

New try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5a73582ba5cd681f5f4fed64591b5bfba8b5e47

Comment 7

[Alexandru Michis [:malexandru]]

Also seeing xpcshell failures: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280288827&repo=autoland&lineNumber=4393

Comment 8

[Julian Descottes [:jdescottes]]

new try https://treeherder.mozilla.org/#/jobs?repo=try&revision=32bd2d8656bf99585eba941a71d81ca3d216d2d3

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd2a261b6786
Reject Error object instead of string in DevTools Front:onPacket r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/b7d37d187a93
Support string errors when detach fails in target fronts r=nchevobbe

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bd2a261b6786
https://hg.mozilla.org/mozilla-central/rev/b7d37d187a93