1526009 - scheduled updates that do not require signoffs show they require a signoff from all teams

Status: RESOLVED WONTFIX

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P3)

Description

[Jordan Lund (:jlund)]

The bug description may be wrong but here is what I'm observing.

I scheduled a change for a widevine rule. I did this so I could queue a lot of changes and have others review it.

I believe once the scheduled time was met, it put the update in effect. I say "I believe" because in this case, it was a scheduled delete and the scheduled change still appears after deadline.

However, while waiting, the UI suggested I needed sign off from every team Balrog knows about. Even though it gave no UI option to sign off.

Screenshots to be attached

Comment 1

[Jordan Lund (:jlund)]

Attachment: Screen Shot 2019-02-07 at 11.23.06 AM.png

Comment 2

[Jordan Lund (:jlund)]

Attachment: Screen Shot 2019-02-07 at 11.19.39 AM.png

Comment 3

[Jordan Lund (:jlund)]

hm, this might have just been because they were localtest channels. still, https://bug1526009.bmoattachments.org/attachment.cgi?id=9042244 probably shouldn't show it requires sign off from all those teams.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Certainly seems like the signoff requirements were incorrectly computed. I'll have a look into why some time.

Comment 5

[[e-mail] (:bhearsum)]

Mass closure of old Balrog UI bugs. We've built a new UI in https://github.com/mozilla-frontend-infra/balrog-ui, and any issues which are still valid should be filed as Issues there.