Closed Bug 1526063 Opened 10 months ago Closed 10 months ago

see if we can remove testing/web-platform/meta/WebCryptoAPI/generateKey/__dir__.ini when the version of NSS bug 1517574 lands in lands in mozilla-central

Categories

(Core :: Security: PSM, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: keeler, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

(In reply to Andrew McCreight [:mccr8] from bug 1517574 comment #8)

> Thanks for looking at this! If you have ASan set up, you could try deleting the file
> testing/web-platform/meta/WebCryptoAPI/generateKey/__dir__.ini and then running
> ./mach wpt WebCryptoAPI/generateKey/ and see if there are any leaks reported.
> If not, you could delete the file as part of your patch.

Bug 1517574 hopefully accounts for all of the leaks in that test directory. If so, we can remove the aforementioned file when the version of NSS that bug 1517574 lands in lands in mozilla-central (see also bug 1523175).

Blocks: 1517309

The leak fix has merged to m-c, and I confirmed locally that all of the LSan leaks in this directory are fixed. Thanks again, Dana.

Assignee: dkeeler → continuation

Bug 1517574 fixed the leaks in this directory, so the white list can
now be removed.

Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f12353abfda
Remove LSan whitelisting for WebCryptoAPI/generateKey/. r=keeler
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.