Closed Bug 1526069 Opened 2 years ago Closed 2 years ago

Port drag and drop code to QuantumBar

Categories

(Firefox :: Address Bar, enhancement, P2)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1526069 - Port drag and drop code to QuantumBar. r=adw!
47 bytes, text/x-phabricator-request
Details | Review

We haven't ported drag and drop to QuantumBar yet:

https://searchfox.org/mozilla-central/rev/490ab7f9b84570573a49d7fa018673ce0d5ddf22/browser/base/content/urlbarBindings.xml#980-1057
https://searchfox.org/mozilla-central/rev/490ab7f9b84570573a49d7fa018673ce0d5ddf22/browser/base/content/urlbarBindings.xml#1804-1832

We should do these, as they contain security handling, and other handling that we need.

We could probably also do with some extra tests - although browser_dragdropURL.js failed (that will need enabling in this bug), there don't appear to be more extensive drag and drop tests (unclear if all the security aspects are covered or not).

Assignee: nobody → mak77
Status: NEW → ASSIGNED
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/e8daa7d594f7
Port drag and drop code to QuantumBar. r=dao

https://hg.mozilla.org/mozilla-central/rev/e8daa7d594f7

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.