Open Bug 1526209 Opened 6 years ago Updated 5 years ago

Phabricator silently drops changes to comments if you mistakenly click Submit mid-edit.

Categories

(Conduit :: Phabricator, defect, P3)

Product:
Conduit
Component:
Phabricator
Type:
defect

Tracking

(Not tracked)

People

(Reporter: bobowen, Unassigned)

References

(
URL
)

Details

(Keywords: conduit-triaged, conduit-upstream)

If you go back to edit a comment and forget to Save Draft, Phabricator still allows you to Submit and just drops the changes.

Ideally the Submit button should be disabled/inactive until you click Cancel or Save Draft on an edit. Preferably with a message saying why it is disabled.

Priority: -- → P1
Priority: -- → P3
Type: enhancement → defect

I and several other people have been hit by this multiple times recently, with pretty bad results. In at least one case, it led to code landing with a significant issue un-addressed, and fortunately getting backed out.

A variant of this happens frequently to me, where I forget to Safe draft on a new comment before hitting Submit, and the comment is dropped entirely.

You need to log in before you can comment on or make changes to this bug.