i noticed that there's no File > Close Window menu item...also, when trying to figure out how to close a tab, i couldn't figure out how to do so --it'd be good to have Close Tab added to the File menu as well. (see also bug 150244, where the current shortcut for tab closing isn't as obvious as cmd+W.)
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → INVALID
Close Window is under the Window menu now, a more MacOS X style placement you'll see appearing in other apps. Again, Close Tab is under the Window menu
The Aqua HIG explicitly prohibits apps from putting close in the window menu; I think we could put the tab commands anywhere we want. "Window menu items appear in this order: Minimize, Zoom, <separator>, <application-specific window commands>, <separator>, Bring All to Front (optional), <separator>, <list of open documents>. The Close command should appear in the File menu, below the Open command."
changing summary to "move Close Tab and Close Window to File menu" It is worth noting that Apple itself doesn't follow the HIG in several places. If anything maybe the commands should be in both places until something more sane is worked out (ha!)
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Summary: add Close Tab and Close Window to File menu → move Close Tab and Close Window to File menu
pinkerton, I'll let you decide on what we want to do with this
Assignee: saari → pinkerton
Status: REOPENED → NEW
FWIW, I also had problems finding the Close Tab menu item, and quickly discovered that Command-W doesn't behave like it does in Mozilla (whose behaviour I like).
Simon, get together with pink and figure out what the "right thing" to do is here.
Close Window and Close Tab should be in the File menu (per discussion with smfr and pink)
Should we go with Command-W to close tabs, until the last one? How about Command-option-W to close a window with several open tabs?
sounds reasonable to me...whatever mozilla does.
I prefer Command-shift-W (instead of Command-Option-W) since that is what Mozilla has and my fingers will get too confused if we are different.
Fine by me. I guess command-option tab is often 'close all windows' in some apps.
hrm, thought i did this earlier
Assignee: pinkerton → sfraser
Isn't Command+Option+W much more commonly used to close all windows in Mac apps?
Have a fix ready to check in. Close Tab and Close Window have been moved to the File menu, in a grouping above Save. Command-W is used as the normal command-key equivalent for Close window, when the key window is a tabless browser window, or any other kind of window. When a browser window with multiple tabs is the key window, then Close Windows gets Command-Shift-W, and Close Tab gets Command-W. Note that floating windows like the Find dialog should be dealt with OK. When you bring up the Find dialog, it becomes the key window, and Command-W will close it. If, while the Find dialog is up, you click on the browser window, then _that_ becomes the key window (even though the Find dialog is frontmost).
Status: NEW → ASSIGNED
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago → 16 years ago
Resolution: --- → FIXED
vrfy'd fixed with 2002.07.08.05 nb.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.