152625 - [FIX]Bookmark/Tab group load focuses first tab in group regardless of 'Load links in the background' pref

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect, P2)

Description

[djk]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1a) Gecko/20020617
BuildID:    2002061707

I have the 'Load links in the background' preference turned on.

When I load a tabgroup, I expect it to obey this pref; load the tabs of the
group in the background.  Instead, the first tab in the group is focused.

Reproducible: Always
Steps to Reproduce:
1. Create a tabgroup
2. Set Tabbed Browsing pref 'Load links in the background' to on (checked)
3. Open the tabgroup


Actual Results:  Tabs in the group are appended to existing tabs, and the first
tab of the group is switched to.

Expected Results:  Tabs in the group are appended to existing tabs, and the
current tab is still focused.

Comment 1

[Stefan Borggraefe]

I can reproduce this with Build 2002062208, Win XP and couldn´t find a
duplicate, so marking NEW.

This bug is a consequence of the behaviour to preserve the already open tabs and
load a bookmark group in new tabs. I believe the "Load links in the background"
pref should be honored whenever links in new tabs are opened. So a more general
bug than this may make sense.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 153018 has been marked as a duplicate of this bug. ***

Comment 3

[Hixie (not reading bugmail)]

jag: do we want to fix this, or is this going to be WONTFIXed?

Comment 4

[jag (Peter Annema)]

I agree that this should be fixed. Caillon, do you want to take this bug?

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: The fix

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

I'd better take this since I have the patch.

Comment 7

[jag (Peter Annema)]

Comment on attachment 95910 [details] [diff] [review]
The fix

there's a pref or prefs global variable that you could reuse :-)

sr=jag if you use that.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 95910 [details] [diff] [review]
The fix

r=sicking

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Landed.

Comment 10

[Prognathous]

This is broken again. Re-opening.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a4) Gecko/20040924

Prog.

Comment 11

[Jason Bassford]

This bug was fixed two years ago.  No doubt, if it is broken, the reasons behind
it being so are now radically different than they were before.

I'm going to mark this FIXED again.  Please create a new case and refer back to
this one.  But one so old should stay closed...