Closed
Bug 1526252
Opened 6 years ago
Closed 6 years ago
Back out bug 1519918 and co from beta.
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
16.58 KB,
patch
|
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
It's zero-risky to back out, and non-zero risk to keep the patches there.
Assignee | ||
Comment 1•6 years ago
|
||
Ryan, could you help with this? Do I need to post patches or just approval to back them out?
We should back out bug 1523181, bug 1524246 and bug 1519918 from beta.
Flags: needinfo?(ryanvm)
Comment 2•6 years ago
|
||
Redirecting to Liz as the 66 release owner, but I think a single backout patch posted here with approval request wouldn't hurt.
Flags: needinfo?(ryanvm) → needinfo?(lhenry)
Comment 3•6 years ago
|
||
Sounds good to me, can you post the patch here and request uplift?
status-firefox66:
--- → affected
tracking-firefox66:
--- → +
Flags: needinfo?(lhenry) → needinfo?(emilio)
Assignee | ||
Comment 4•6 years ago
|
||
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
Bugs being backed out
User impact if declined
Unknown but non-zero compared to backing these out.
Is this code covered by automated tests?
No
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
No
If yes, steps to reproduce
List of other uplifts needed
None
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
Backing-out pre-existing uplifts and the patch that caused them to get uplifted.
String changes made/needed
none
Assignee: nobody → emilio
Flags: needinfo?(emilio)
Attachment #9042630 -
Flags: approval-mozilla-beta?
Comment 5•6 years ago
|
||
Comment on attachment 9042630 [details] [diff] [review]
Back out bugs 1519918, 1524246 and 1523181 from beta.
Backout for crash, memory leaks.
This should land for beta 7.
Attachment #9042630 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•