Closed Bug 1526301 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15005 - Update cached azimuth/elevation/cone gain

Categories

(Core :: Web Audio, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15005 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15005
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Update cached azimuth/elevation/cone gain

Sample accurate panner automations need to update the cached value for
the azimuth, elevation, and cone gain at the end of each render in
case the automations end (because all automations are sufficiently far
in the past). When this happens, the panner switches from a-rate
sample-accurate method to k-rate method that uses the cached values
when nothing is moving. If the a-rate method doesn't update, then the
k-rate method uses the old values which are now incorrect.

Bug: 917757
Test: the-panner-node/automation-changes.html
Change-Id: I7289c278b1cc9dc31d9e3f5698ac467cb1474ca5
Reviewed-on: https://chromium-review.googlesource.com/c/1427795
Commit-Queue: Raymond Toy \<rtoy@chromium.org>
Reviewed-by: Hongchan Choi \<hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627129}

Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 1 tests and 2 subtests
PASS   : 2
ERROR  : 1

New tests that have failures or other problems:
/webaudio/the-audio-api/the-pannernode-interface/automation-changes.html: ERROR
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8838994da47
[wpt PR 15005] - Update cached azimuth/elevation/cone gain, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/b44cdc90a575
[wpt PR 15005] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.