Closed
Bug 1526318
Opened 5 years ago
Closed 5 years ago
Add assertions XrayResolveAttribute is not called with selfhosted getters
Categories
(Core :: DOM: Bindings (WebIDL), enhancement)
Core
DOM: Bindings (WebIDL)
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
1.45 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
XrayResolveAttribute directly accesses JSPropertySpec::accessors::getters::native without a prior check if the getter is self-hosted (or an accessor in the first place). Let's add some assertions to catch misuse more nicely than obscure crashes when later trying to reinterpret a SelfHostedWrapper as a JSNativeWrapper.
|
Assignee | |
Comment 1•5 years ago
|
||
Assert correct use of XrayResolveAttribute, so we don't crash later on when retrieving the JSPropertySpec fields.
Attachment #9042484 -
Flags: review?(bzbarsky)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9042484 [details] [diff] [review] bug1526318.patch r=me
Attachment #9042484 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba7b45e248eb074e51c094a611c9c55da8562266
Keywords: checkin-needed
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6995ea68c908
Assert the JSPropertySpec in XrayResolveAttribute has a native accessor function. r=bz
Keywords: checkin-needed
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•