1526379 - [ja] In-content Clear All History dialog isn't wide enough in Japanese locale

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Walter Labonte]

Attachment: dialog.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Options -> Privacy & Security -> Clear History

Actual results:

A decent dialog appeared.

Expected results:

Lack of right side of the option dialog on 'ja' language pack
Concerned with https://bugzilla.mozilla.org/show_bug.cgi?id=1523696

Comment 1

[Walter Labonte]

Attachment: ok20190205215922.png

It was OK on Nightyly 67.0a1 (2019-02-05) build id: 20190205215922, 'ja' locale.

Comment 2

[:Gijs (he/him)]

Interesting... would be curious to know what broke this.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=476293c6700fb45da40b8096184211432a89be57&tochange=00432a450b3af67c4d5711810691b27093880c62

Comment 4

[:Gijs (he/him)]

(In reply to Alice0775 White from comment #3)

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=476293c6700fb45da40b8096184211432a89be57&tochange=00432a450b3af67c4d5711810691b27093880c62

Huh. None of the obvious suspects from recent history are in that window.

I don't see any relevant ja locale changes in this time window either. Alice, if you're able to narrow the regression window down further that'd be really helpful.

Comment 5

[Alice0775 White]

Please ignore comment#3.

Correct regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=476293c6700fb45da40b8096184211432a89be57&tochange=3a3e393396f418df1490aa0832d0c54fc353d522

Suspect:
d599d1a73a3a Tim Nguyen — Bug 1525747 - Remove XUL grid layout from browser/components/preferences/sanitize.xul. r=Gijs

Comment 6

[:Gijs (he/him)]

:ntim, please take a look.

Comment 7

[Alice0775 White]

Gijs, thanks.

Comment 8

[Tim Nguyen :ntim]

It can't be bug 1525747 since that's a different dialog (though it may also be affected by this issue), bug 1525739 is more likely.

Comment 9

[Tim Nguyen :ntim]

Attachment: Bug 1526379 - Use <vbox> instead of <box> to make the children stretch horizontally in sanitize dialogs. r=Gijs

Comment 10

[Tim Nguyen :ntim]

The issue here was that I used <box> instead of <vbox> for the second section of the dialog. Since XUL flex layouts have -moz-box-align: stretch, this makes a difference, because <vbox> will make the child checkbox stretch horizontally instead of vertically like <box> does. The horizontal stretching restricts the checkbox dimension and forces the checkbox to wrap its content.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b08ce769c436
Use <vbox> instead of <box> to make the children stretch horizontally in sanitize dialogs. r=Gijs

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b08ce769c436

Comment 13

[:Gijs (he/him)]

Walter or Alice, could you please verify the issue is gone for you in latest nightly? Thank you.

Comment 14

[Walter Labonte]

Attachment: fixed.jpg

I have confirmed it's fixed. Thank you for fixing!
Nightly 67.0a1 (2019-02-18) build id 20190218214558

Comment 15

[:Gijs (he/him)]

Thanks!