1526394 - Treat self-hosted builtins the same as native functions in the debugger

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[André Bargull [:anba]]

• Return undefined instead of null in the script getter.
  • That way self-hosted getters are treated as safe-getters in DevTools.
  • I have an experimental patch to change get TypedArray.prototype.byteLength to a self-hosted getter which requires this change to avoid an xpc test suite failure.
• Don't expose the environment in the environment getter.

Comment 1

[André Bargull [:anba]]

Attachment: bug1526394.patch

Changes the JSFunction::isInterpreted() calls to also test for self-hosted builtins.

Drive-by fix:

• Refer to "asm.js" instead of "wasm" to make a comment less confusing.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 9042552 [details] [diff] [review]
bug1526394.patch

Review of attachment 9042552 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this review. Looks great.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:anba, could you have a look please?

Comment 4

[André Bargull [:anba]]

Attachment: bug1526394.patch

Updated patch to apply cleanly on inbound and to fix a devtools test, which expected to be able to retrieve the parameter names of self-hosted functions. Carrying r+.

Comment 5

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=239a7bb65ac0c328fe38a4952ec9d43fcaeccef6

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b8e1b1b70f3
Treat self-hosted functions the same as non-interpreted functions in Debugger code. r=jorendorff

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9b8e1b1b70f3

Comment 8

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/9b8e1b1b70f326cc8170b3a26c4321e360632a2d
Bug 1526394: Treat self-hosted functions the same as non-interpreted functions in Debugger code. r=jorendorff