1526418 - Options/preferences don't apply instantly in Thunderbird Daily

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

Thunderbird Daily has in-content preferences, but at the moment they don't apply (at least not in Windows).

STR:

1. Go to Tools > Options and change a setting that should apply instantly, e.g. the location of the start page on the General pane, or the way you forward messages on the Composition pane, General tab;
2. Invoke the function you changed in step 1 (press Alt-Home in 3-pane view or press Ctrl+L to forward a message);
3. See that the original setting is invoked (old start page, message still attached instead of included, etc)

(This is probably caused by the removal of the binding, but I don't have that bug number at hand to put in the dependencies.)

Comment 1

[Onno Ekker [:nONoNonO UTC+1]]

Forgot to add some info/background: with in-content prefs there's no more OK/Cancel button, but the changed should apply instantly. The pref browser.preferences.instantApply used to take care of this, but with mail.preferences.inContent default (and not as an option anymore) there's no way to make preferences apply at the moment

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1526418-set-instantApply-true.patch

The prefs in tab always set the instantApply to true, see https://hg.mozilla.org/comm-central/diff/1f1658927d2d/mail/components/preferences/aboutPreferences.xml#l1.95. Now that we have only the in-content prefs only, we should set it on true on Windows too.

Comment 3

[Jorg K (CEST = GMT+2)]

Hmm, I can't reproduce the problem in the first place.

If I switch to inline/as attachment or change the start page URL, then invoke the function, the new value is used, after switching back to the 3pane of course.

browser.preferences.instantApply is already true, even if I switch it to false, it's set to true when I check the next time.

I don't think the patch fixes anything.

Comment 4

[Richard Marti (:Paenglab)]

Also if it doesn't fix the issue that I'm not seeing, we should set the pref to true as default on Windows as it is set to true anyway. Then it reflects the real state.

Comment 5

[Jorg K (CEST = GMT+2)]

Well, FF still has it this way:
https://searchfox.org/mozilla-central/rev/03ebbdab952409640c6857d835d3040bf6f9e2db/browser/app/profile/firefox.js#719

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

I think for me it will fixes it after all. The setting looks user set, but it really isn't or is, but maybe too late:
When I toggle it to it's default state false and restart Daily, it looks set to true again.
When I toggled it to false and then to true again and retsarted Daily, I don't think it got stored in my prefs.js.
When I added it manually to my prefs.js as set to true, the settings do apply again:
user_pref("browser.preferences.instantApply", true);

Comment 7

[Richard Marti (:Paenglab)]

FF doesn't use this pref in the prefs. In the prefs it's also always true. I know where is a bug around to remove this pref (bug 1325637).

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1526418-set-instantApply-true.patch

Removed a #ifdef too much.

Comment 9

[:aceman]

I could not reproduce it on Linux e.g. with the start page.

But TB does use the instanApply pref in a few places, like https://searchfox.org/comm-central/source/mail/components/preferences/subdialogs.js#53 or https://searchfox.org/comm-central/source/mail/base/content/mailCore.js#487

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 9042739 [details] [diff] [review]
1526418-set-instantApply-true.patch

OK, I reproduced the problem now.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0b73fc8ae5e9
Set browser.preferences.instantApply to true on all platforms. r=jorgk

Comment 12

[Jorg K (CEST = GMT+2)]

TB 66 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/43225f621c4ca63904f299ccf589e0bc5a88eebd