Closed Bug 1526428 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 15187 - Make Japanese linebreaking tests more robust against rounding

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15187 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15187
Details from upstream follow.

Dominik Röttsches <drott@chromium.org> wrote:

Make Japanese linebreaking tests more robust against rounding

These tests were comparing offsetLeft, but there were pixel differences
which made some of the tests fails. Using a less than 1
getClientBoundingRect().left difference instead, cleaning up the code
and removing expectations file due to these robustly passing now. The
pixel differences are not relevant to the intention of the test.

Bug: 927287
Change-Id: I5235489457183aa7a3ea25b40ccfa96dfef3f980
Reviewed-on: https://chromium-review.googlesource.com/c/1448451
Auto-Submit: Dominik Röttsches \<drott@chromium.org>
Commit-Queue: Philip Jägenstedt \<foolip@chromium.org>
Reviewed-by: Philip Jägenstedt \<foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627998}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 18 tests and 258 subtests
OK     : 18
PASS   : 114
FAIL   : 144
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb0d176402ba
[wpt PR 15187] - Make Japanese linebreaking tests more robust against rounding, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.