1526448 - [wpt-sync] Sync PR 15162 - Don't skip invalid functions when looking for var references.

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 15162 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15162
Details from upstream follow.

Emilio Cobos Álvarez <[e-mail]> wrote:

Don't skip invalid functions when looking for var references.

This matches the spec, WebKit and Firefox.

From https://drafts.csswg.org/css-variables/#using-variables:

If a property contains one or more var() functions, and those functions are
syntactically valid, the entire property’s grammar must be assumed to be
valid at parse time. It is only syntax-checked at computed-value time, after
var() functions have been substituted.

Bug: 921152
Change-Id: Ie46268ffae4e01f457f379c674e0cf1a7ccea354
Reviewed-on: https://chromium-review.googlesource.com/c/1446653
Commit-Queue: Rune Lillesveen \<[e-mail]>
Reviewed-by: Rune Lillesveen \<[e-mail]>
Reviewed-by: Eric Willigers \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#628023}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffcaa38659da70465338b576430d38f6cf5994fb

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=672c13430fefaa4cd091ac7395efc5d0de455b30

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 2 tests and 5 subtests
OK     : 2
PASS   : 5

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7fed89d3736
[wpt PR 15162] - Don't skip invalid functions when looking for var references., a=testonly

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/a7fed89d3736