Closed Bug 1526467 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 15026 - Portals: Send detach message to browser process for portals

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15026 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15026
Details from upstream follow.

Adithya Srinivasan <adithyas@chromium.org> wrote:

Portals: Send detach message to browser process for portals

We don't currently send a message because the RenderFrameProxy created
has no parent (so it looks like a main frame). This ensures that
same-origin frames within the portal are also detached.

The test added would fail with --enable-leak-detection without this
change (the iframe inside the portal would leak).

Bug: 923898
Change-Id: I2b56b8e303b40d275976da5ed8a0fdde7726b51c
Reviewed-on: https://chromium-review.googlesource.com/c/1430586
Reviewed-by: Daniel Cheng \<dcheng@chromium.org>
Reviewed-by: Charlie Reis \<creis@chromium.org>
Reviewed-by: Lucas Gadani \<lfg@chromium.org>
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan \<adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628179}

Ran 1 tests and 1 subtests
TIMEOUT: 2

New tests that have failures or other problems:
/portals/portals-cross-origin-load.sub.html: TIMEOUT
    portals-cross-origin-load: TIMEOUT
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09befdcd331f
[wpt PR 15026] - Portals: Send detach message to browser process for portals, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3150b479cad2
[wpt PR 15026] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.