Closed Bug 1526517 Opened 1 year ago Closed 1 year ago

Restrict adjust-to-low-end-hardware feature to nightly-only for now

Categories

(Firefox :: General, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: mconley, Assigned: Gijs)

References

Details

Attachments

(1 file)

This will simplify rolling this out as a Shield experiment.

Originally, we had considered using https://github.com/nhnt11/multipreffer to flip the necessary prefs (performance.adjust_to_machine and performance.low_end_machine) to true.

The problem is, however, that there's code here:

https://searchfox.org/mozilla-central/rev/03ebbdab952409640c6857d835d3040bf6f9e2db/toolkit/components/gfx/SanityTest.js#354

that will clear the performance.low_end_machine pref in later Beta's, which we're starting to come up to.

Either we can aim to only run this experiment in an early Beta (in which case, we'll probably need to wait for Beta 67) with an add-on, or we need to land (and uplift?) a pref that turns this whole thing on or off for the experiment.

Blocks: 1503339

Hey Gijs, how safe and simple would it be to write and uplift a patch that allows us to toggle the "low end" state for qualified clients, without wiping it out until the end of the experiment?

Flags: needinfo?(gijskruitbosch+bugs)

Talked to Mike, we're going to make this live behind the single pref we already have, but just make sure it's always off on beta (for now).

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Summary: Add a single pref to control the low-end hardware experiment → Restrict adjust-to-low-end-hardware feature to nightly-only for now
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/37bfe206487b
disable low-end-machine adjustment for beta and limit to nightly builds, r=mconley
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Blocks: 1527368
You need to log in before you can comment on or make changes to this bug.