[wpt-sync] Sync PR 15238 - [css-flexbox] Don't apply min-height: auto to children with percentage heights
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 15238 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/15238
Details from upstream follow.
Christian Biesinger <cbiesinger@chromium.org> wrote:
[css-flexbox] Don't apply min-height: auto to children with percentage heights
In such a case, we compute an incorrect intrinsic logical height, because
we resolve pre-flex percentages when we calculate the intrinsic height.
In common cases this can be 100% of the flexbox height, which we later
use as a min-height of the flex item, leading to it not shrinking when
it should.This reverts https://crrev.com/c/1269235 for the case of a flex item
which is a flexbox with percentage children.Bug: 927066
Change-Id: I955bf651f75495122bb454d5221303b188bbb03c
Reviewed-on: https://chromium-review.googlesource.com/c/1452477
Commit-Queue: Christian Biesinger \<cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund \<eae@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Auto-Submit: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628806}
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e193d46672696c54f6b257940db0e46fe1afcf9
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e4cc4709ae0cabcdc49437462302cccbcd5794c
Assignee | ||
Comment 3•5 years ago
|
||
Ran 1 tests and 1 subtests OK : 1 PASS : 1
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/863b743c28df [wpt PR 15238] - [css-flexbox] Don't apply min-height: auto to children with percentage heights, a=testonly
Comment 5•5 years ago
|
||
bugherder |
Description
•