Don't show messages with different execution points as repeated

RESOLVED FIXED in Firefox 67

Status

()

defect
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

5 months ago
Posted patch patchSplinter Review

The console UI consolidates repeated messages into a single entry. When replaying, each of these messages have their own execution point which can be seeked to, and consolidating them prevents being able to do this. The simplest solution for now is to just not consolidate them, which this patch does by treating the execution point as part of the state used when looking for repeating messages.

Attachment #9042683 - Flags: review?(nchevobbe)
Assignee

Updated

5 months ago
Blocks: webreplay-console
No longer blocks: replay-m1
Comment on attachment 9042683 [details] [diff] [review]
patch

Review of attachment 9042683 [details] [diff] [review]:
-----------------------------------------------------------------

That looks good to me, thanks Brian. it would be nice to have a test for this so we don't regress in the future
Attachment #9042683 - Flags: review?(nchevobbe) → review+

Comment 2

4 months ago
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57243d949492
Don't show messages with different execution points as repeated, r=nchevobbe.

Comment 3

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.