Closed
Bug 1526561
Opened 6 years ago
Closed 6 years ago
Don't show messages with different execution points as repeated
Categories
(Core Graveyard :: Web Replay, defect)
Core Graveyard
Web Replay
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
436 bytes,
patch
|
nchevobbe
:
review+
|
Details | Diff | Splinter Review |
The console UI consolidates repeated messages into a single entry. When replaying, each of these messages have their own execution point which can be seeked to, and consolidating them prevents being able to do this. The simplest solution for now is to just not consolidate them, which this patch does by treating the execution point as part of the state used when looking for repeating messages.
Attachment #9042683 -
Flags: review?(nchevobbe)
|
Assignee | |
Updated•6 years ago
|
Comment on attachment 9042683 [details] [diff] [review]
patch
Review of attachment 9042683 [details] [diff] [review]:
-----------------------------------------------------------------
That looks good to me, thanks Brian. it would be nice to have a test for this so we don't regress in the future
Attachment #9042683 -
Flags: review?(nchevobbe) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57243d949492
Don't show messages with different execution points as repeated, r=nchevobbe.
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
||
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•