Specify location correctly in replaying log point messages

RESOLVED FIXED in Firefox 67

Status

()

defect
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

5 months ago
Posted patch patchSplinter Review

When converting virtual console log messages into the form expected for a console API call, the URL/line/column are hacked into the message arguments instead of being specified with the right properties of the API message packet. The attached patch fixes this so that the console UI shows locations for replaying log point messages in the same way as normal console messages.

Attachment #9042684 - Flags: review?(lsmyth)
Assignee

Updated

5 months ago
Blocks: webreplay-console
No longer blocks: replay-m1
Attachment #9042684 - Flags: review?(lsmyth) → review+

Comment 1

4 months ago
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb355b458bbf
Specify location correctly in replaying log point messages, r=lsmyth.

Comment 2

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.