Closed Bug 1526562 Opened 7 years ago Closed 7 years ago

Specify location correctly in replaying log point messages

Categories

(Core Graveyard :: Web Replay, defect)

Product:
Core Graveyard
Component:
Web Replay
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

patch
993 bytes, patch
loganfsmyth
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review

When converting virtual console log messages into the form expected for a console API call, the URL/line/column are hacked into the message arguments instead of being specified with the right properties of the API message packet. The attached patch fixes this so that the console UI shows locations for replaying log point messages in the same way as normal console messages.

Attachment #9042684 - Flags: review?(lsmyth)
Blocks: webreplay-console
No longer blocks: replay-m1
Attachment #9042684 - Flags: review?(lsmyth) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cb355b458bbf Specify location correctly in replaying log point messages, r=lsmyth.

https://hg.mozilla.org/mozilla-central/rev/cb355b458bbf

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: