Closed Bug 1526606 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 15263 - XMLSerializer: Fix conflict between a generated ns* prefix and existing xmlns:ns*.

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15263 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15263
Details from upstream follow.

Kent Tamura <tkent@chromium.org> wrote:

XMLSerializer: Fix conflict between a generated ns* prefix and existing xmlns:ns*.

This CL restores the loop removed in crrev.com/629490.
The new behavior matches to Firefox though it doesn't conform to the
specification.

Add a test case to WPT based on the current specification, and
Blink has a failing expectation.

Bug: 928639
Change-Id: Ica431543440b538400cf1af086cab27cf59c4dc8
Reviewed-on: https://chromium-review.googlesource.com/c/1454023
Auto-Submit: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue \<yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue \<yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629842}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 15263 applied with additional changes from upstream: d2c49d8610185244a31e04ef32aae70da0dd35f7
Component: web-platform-tests → DOM
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 6 subtests
OK     : 1
PASS   : 4
FAIL   : 2

New tests that have failures or other problems:
/domparsing/XMLSerializer-serializeToString.html
    Check if "ns1" is generated even if the element already has xmlns:ns1.: FAIL
    Check if generated prefixes match to "ns${index}".: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e79631753f0
[wpt PR 15263] - XMLSerializer: Fix conflict between a generated ns* prefix and existing xmlns:ns*., a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1955026df01
[wpt PR 15263] - XMLSerializer: Fix conflict between a generated ns* prefix and existing xmlns:ns*., a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.