1526614 - Intermittent toolkit/components/passwordmgr/test/browser/browser_private_window.js | notification should not be dismissed -

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: shindli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=227342319&repo=autoland

https://queue.taskcluster.net/v1/task/c3W5g69uQruQtMky5bkrNA/runs/0/artifacts/public/logs/live_backing.log

[task 2019-02-09T03:57:14.377Z] 03:57:14 INFO - Buffered messages logged at 03:57:10
[task 2019-02-09T03:57:14.378Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Checking submitted username -
[task 2019-02-09T03:57:14.379Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Checking submitted password -
[task 2019-02-09T03:57:14.380Z] 03:57:14 INFO - Leaving test bound test_normal_autofilled_10
[task 2019-02-09T03:57:14.381Z] 03:57:14 INFO - Entering test bound test_normal_http_basic_auth
[task 2019-02-09T03:57:14.382Z] 03:57:14 INFO - test normal/basic-auth: verify that we get a doorhanger after basic-auth login
[task 2019-02-09T03:57:14.387Z] 03:57:14 INFO - Buffered messages logged at 03:57:12
[task 2019-02-09T03:57:14.388Z] 03:57:14 INFO - Got prompt: [object XULDocument]
[task 2019-02-09T03:57:14.389Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Got expected HTTP auth dialog Dialog.ui -
[task 2019-02-09T03:57:14.390Z] 03:57:14 INFO - Buffered messages logged at 03:57:13
[task 2019-02-09T03:57:14.391Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Auth-required page loaded -
[task 2019-02-09T03:57:14.400Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Checking authorization passed -
[task 2019-02-09T03:57:14.403Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Checking authorized username -
[task 2019-02-09T03:57:14.404Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Checking authorized password -
[task 2019-02-09T03:57:14.405Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Looking for password-save popup notification -
[task 2019-02-09T03:57:14.408Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Notification type matches. -
[task 2019-02-09T03:57:14.410Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Main action label matches save doorhanger. -
[task 2019-02-09T03:57:14.411Z] 03:57:14 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | got notification popup -
[task 2019-02-09T03:57:14.413Z] 03:57:14 INFO - Buffered messages finished
[task 2019-02-09T03:57:14.414Z] 03:57:14 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_private_window.js | notification should not be dismissed -
[task 2019-02-09T03:57:14.416Z] 03:57:14 INFO - Stack trace:
[task 2019-02-09T03:57:14.420Z] 03:57:14 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2019-02-09T03:57:14.421Z] 03:57:14 INFO - chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_private_window.js:test_normal_http_basic_auth/<:498
[task 2019-02-09T03:57:14.422Z] 03:57:14 INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
[task 2019-02-09T03:57:14.424Z] 03:57:14 INFO - chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_private_window.js:test_normal_http_basic_auth:473
[task 2019-02-09T03:57:14.427Z] 03:57:14 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
[task 2019-02-09T03:57:14.429Z] 03:57:14 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2019-02-09T03:57:14.429Z] 03:57:14 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
[task 2019-02-09T03:57:14.430Z] 03:57:14 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-02-09T03:57:14.432Z] 03:57:14 INFO - GECKO(6367) | --DOCSHELL 0xe7215400 == 5 [pid = 6603] [id = {739453be-d2f7-4885-8fc9-58119a97de10}]
[task 2019-02-09T03:57:14.433Z] 03:57:14 INFO - GECKO(6367) | --DOCSHELL 0xe7217800 == 4 [pid = 6603] [id = {143dfca2-328e-48d5-ae19-9e34bd783a96}]
[task 2019-02-09T03:57:14.434Z] 03:57:14 INFO - GECKO(6367) | --DOMWINDOW == 20 (0xf706ec60) [pid = 6603] [serial = 20] [outer = (nil)] [url = https://example.com//browser/toolkit/components/passwordmgr/test/browser/formsubmit.sjs?user=notifyu1&pass=notifyp1]
[task 2019-02-09T03:57:14.437Z] 03:57:14 INFO - GECKO(6367) | --DOMWINDOW == 19 (0xf706ff60) [pid = 6603] [serial = 24] [outer = (nil)] [url = https://example.com//browser/toolkit/components/passwordmgr/test/browser/formsubmit.sjs?user=notifyu1&pass=notifyp1]
[task 2019-02-09T03:57:14.440Z] 03:57:14 INFO - GECKO(6367) | --DOMWINDOW == 18 (0xf706eff0) [pid = 6603] [serial = 32] [outer = (nil)] [url = https://example.com//browser/toolkit/components/passwordmgr/test/browser/formsubmit.sjs?pass=notifyp1&newpass=notifyp2]
[task 2019-02-09T03:57:14.442Z] 03:57:14 INFO - GECKO(6367) | --DOMWINDOW == 17 (0xf706ed90) [pid = 6603] [serial = 28] [outer = (nil)] [url = https://example.com//browser/toolkit/components/passwordmgr/test/browser/formsubmit.sjs?pass=notifyp1&newpass=notifyp2]
[task 2019-02-09T03:57:14.443Z] 03:57:14 INFO - GECKO(6367) | --DOMWINDOW == 16 (0xf7070c70) [pid = 6603] [serial = 36] [outer = (nil)] [url = https://example.com//browser/toolkit/components/passwordmgr/test/browser/formsubmit.sjs?user=&pass=]
[task 2019-02-09T03:57:14.445Z] 03:57:14 INFO - GECKO(6367) | --DOCSHELL 0xe7212400 == 3 [pid = 6603] [id = {9a3cef00-c32b-432d-a01e-6dcf1a4ce941}]
[task 2019-02-09T03:57:14.446Z] 03:57:14 INFO - GECKO(6367) | --DOCSHELL 0xe721a800 == 2 [pid = 6603] [id = {90ee13b8-5130-43d8-8936-06319f53eeab}]
[task 2019-02-09T03:57:14.449Z] 03:57:14 INFO - GECKO(6367) | --DOCSHELL 0xe7217000 == 1 [pid = 6603] [id = {c8922443-9ddc-45f9-ac21-ee319f8d0fb1}]
[task 2019-02-09T03:57:14.450Z] 03:57:14 INFO - Leaving test bound test_normal_http_basic_auth
[task 2019-02-09T03:57:14.455Z] 03:57:14 INFO - Entering test bound test_private_http_basic_auth
[task 2019-02-09T03:57:14.461Z] 03:57:14 INFO - test private/basic-auth: verify that we don't get a doorhanger after basic-auth login

Comment 1

[Andreea Pavel [:apavel]]

This is from Bug 1520960, Matthew can you please take a look?

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cdebug%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux32%2Fdebug-mochitest-browser-chrome-e10s-1%2Cm-e10s%28bc1%29&tochange=ce5c1acaf3674177e10188e4a252fcecef62c3ea&fromchange=2eec2334d48f802400626fe307a73f2ef689d9c7&group_state=expanded&selectedJob=227342319

Comment 2

[Intermittent Failures Robot]

30 failures in 204 pushes (0.147 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 10
• try: 1
• mozilla-inbound: 3
• autoland: 16

Platform breakdown:

• linux64: 21
• linux32: 7
• linux64-ccov: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-09&endday=2019-02-09&tree=all

Comment 3

[Intermittent Failures Robot]

50 failures in 2658 pushes (0.019 failures/push) were associated with this bug in the last 7 days.

This is the #44 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 21
• try: 4
• mozilla-inbound: 9
• mozilla-central: 16

Platform breakdown:

• linux32: 9
• linux64: 38
• linux64-ccov: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-04&endday=2019-02-10&tree=all

Comment 4

[Narcis Beleuzu [:NarcisB]]

There are 53 failures in the last 3 days.
All failures are on Linux:

• linux64 -> 36 failures
• linux32 -> 14 failures
• linux64-ccov -> 3 failures

Started from https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=227453636&revision=5656f8b5c547fdcaf09a274b12d1aa0ab07631fa

:sfoster , could you please take a look?

Comment 5

[Matthew N. [:MattN]]

Sam can take this

Comment 6

[Intermittent Failures Robot]

47 failures in 533 pushes (0.088 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-inbound: 14
• autoland: 23
• mozilla-central: 7
• try: 3

Platform breakdown:

• linux64: 27
• linux32: 18
• linux64-ccov: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-11&endday=2019-02-11&tree=all

Comment 7

[Sam Foster [:sfoster] (he/him)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=543&selectedJob=227809821

Comment 8

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1526614 - Focus window and wait when testing if notification is dismissed, re-enable test on Linux r?MattN

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/651aa8d03082
Wait when testing if notification is dismissed. r=MattN

Comment 10

[Intermittent Failures Robot]

58 failures in 564 pushes (0.103 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• try: 1
• mozilla-central: 12
• autoland: 25
• mozilla-inbound: 20

Platform breakdown:

• linux64-ccov: 3
• linux32: 19
• linux64: 36

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-12&endday=2019-02-12&tree=all

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/651aa8d03082

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dede03809a93
Backed out changeset 651aa8d03082 for permafailing on browser_private_window.js

Comment 13

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-9%2Cm-e10s%28bc9%29&revision=651aa8d03082e7cc31ea809c4755a2b0500e8cbe&selectedJob=228176355

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228176355&repo=autoland&lineNumber=4538

Backout link: https://hg.mozilla.org/integration/autoland/rev/dede03809a93

[task 2019-02-13T14:12:08.999Z] 14:12:08 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Main action label matches save doorhanger. -
[task 2019-02-13T14:12:09.001Z] 14:12:09 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | got notification popup -
[task 2019-02-13T14:12:09.003Z] 14:12:09 INFO - Buffered messages finished
[task 2019-02-13T14:12:09.006Z] 14:12:09 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Uncaught exception - notification should not be dismissed - timed out after 50 tries.
[task 2019-02-13T14:12:09.008Z] 14:12:09 INFO - Leaving test bound test_normal_http_basic_auth
[task 2019-02-13T14:12:09.009Z] 14:12:09 INFO - Entering test bound test_private_http_basic_auth
[task 2019-02-13T14:12:09.011Z] 14:12:09 INFO - test private/basic-auth: verify that we don't get a doorhanger after basic-auth login
[task 2019-02-13T14:12:09.013Z] 14:12:09 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Expect signon.privateBrowsingCapture.enabled to default to true -
[task 2019-02-13T14:12:09.402Z] 14:12:09 INFO - Got prompt: [object XULDocument]
[task 2019-02-13T14:12:09.404Z] 14:12:09 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_private_window.js | Got expected HTTP auth dialog Dialog.ui -

Comment 14

[Intermittent Failures Robot]

62 failures in 469 pushes (0.132 failures/push) were associated with this bug yesterday.

Repository breakdown:

• oak: 1
• mozilla-central: 5
• try: 18
• autoland: 34
• mozilla-inbound: 4

Platform breakdown:

• linux32: 18
• linux64-nightly: 1
• linux32-devedition: 1
• linux64: 40
• linux64-devedition: 1
• linux64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-13&endday=2019-02-13&tree=all

Comment 15

[Intermittent Failures Robot]

50 failures in 471 pushes (0.106 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 10
• try: 14
• mozilla-inbound: 5
• autoland: 21

Platform breakdown:

• linux64: 28
• linux32: 19
• linux64-ccov: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-14&endday=2019-02-14&tree=all

Comment 16

[Sam Foster [:sfoster] (he/him)]

I've tried just skipping asan and debug builds on Linux, but I'm seeing the same failures now on linux-x64-opt:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e960d3861abff6afc32bf33d806269d951d20190&selectedJob=228766013

I'm no closer to knowing why the notification has been dismissed. I had thought maybe some other notification was popping up which would dismiss the save password one, but that would presumably be caught in the screenshot if it was the case.

Disabling the test on linux entirely wold be a short-term fix if we need one. I'm going to continue to investigate meantime.

Comment 17

[Cosmin Sabou [:CosminS]]

Attachment: Bug 1526614 - Disable toolkit/components/passwordmgr/test/browser/browser_private_window.js on linux.

Comment 18

[Intermittent Failures Robot]

47 failures in 588 pushes (0.08 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 20
• mozilla-inbound: 5
• mozilla-central: 14
• try: 8

Platform breakdown:

• linux32: 14
• linux32-nightly: 1
• android-hw-p2-8-0-android-aarch64: 1
• linux64: 26
• linux64-ccov: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-15&endday=2019-02-15&tree=all

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cd5ad8016bd5

Comment 20

[Intermittent Failures Robot]

29 failures in 121 pushes (0.24 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-inbound: 9
• autoland: 11
• mozilla-central: 6
• try: 3

Platform breakdown:

• linux32: 11
• linux64-ccov: 1
• linux64: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-16&endday=2019-02-16&tree=all

Comment 21

[Intermittent Failures Robot]

309 failures in 2832 pushes (0.109 failures/push) were associated with this bug in the last 7 days.

This is the #1 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 134
• oak: 1
• mozilla-central: 54
• try: 63
• mozilla-inbound: 57

Platform breakdown:

• linux64: 182
• linux32-nightly: 1
• linux64-ccov: 15
• linux32: 107
• linux32-devedition: 1
• linux64-nightly: 1
• android-hw-p2-8-0-android-aarch64: 1
• linux64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-11&endday=2019-02-17&tree=all

Comment 22

[Sam Foster [:sfoster] (he/him)]

The latest try push looks better but still one failure (so far, I re-triggered some more times) on linux-opt so its not fully fixed:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d536c5ba4c134def07df9af9384575bfb10c21f&selectedJob=229463275

Comment 23

[Sam Foster [:sfoster] (he/him)]

New patch and try push at: https://treeherder.mozilla.org/#/jobs?repo=try&revision=01b6a2926d5230f2912f3c020f2f802ee87e00a2
Looking good, fingers crossed.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c062f6742b11
Focus window and wait when testing if notification is dismissed, re-enable test on Linux r=MattN

Comment 25

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c062f6742b11

Comment 26

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c062f6742b11

Comment 27

[Intermittent Failures Robot]

8 failures in 2602 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 8

Platform breakdown:

• linux64: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1526614&startday=2019-02-18&endday=2019-02-24&tree=all